fix restore from home trash on a separate home volume - #403
Open
curious-rabbit wants to merge 2 commits into
Open
fix restore from home trash on a separate home volume#403curious-rabbit wants to merge 2 commits into
curious-rabbit wants to merge 2 commits into
Conversation
Owner
|
Explain better with examples. |
Author
|
When /home (or XDG_DATA_HOME) is a separate mount, files trashed to the home trash cannot be restored. The home trash records absolute paths, and absolute paths were rejected on any volume other than /. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
parse_original_location rejected absolute Path= entries whenever the trash volume was not "/". The home trash uses absolute paths, so if /home (or XDG_DATA_HOME) is a separate mount, every home-trash entry became unrestorable. Now accept absolute paths. still reject relative paths that escape the volume.