chore: update go-package-spec for package-spec 3.6.6 - #73
Merged
Conversation
Bump github.com/andrewkroh/go-package-spec to pick up support for package-spec 3.6.6 (go-package-spec#26). What changes in the database: - The `packages` table gains a `group` column, holding the new top-level `group` field from integration, input, and content manifests. Packages that share a value belong to the same marketplace group. Kibana owns the group's title, icon, and description; the manifest field only declares membership, and values are not validated against Kibana's group list. The column name is quoted in SQL because `group` is a SQLite keyword, so queries need `SELECT "group" FROM packages`. No package in elastic/integrations sets it yet, so the column is currently NULL everywhere. - Content packages may now ship saved search assets in `kibana/search/`, and those rows land in `kibana_saved_objects` with `asset_type = 'search'`. Integration packages could already do this; 3.6.6 extends it to content packages. No schema change for the other 3.6.6 additions. Policy tests gained an `ignore_fields` setting, but it lives in the package-level _dev/test/config.yml, which is not indexed. The remaining changes are package-spec validation and tooling only. Verified by building the database from a local elastic/integrations checkout: 479 packages load, the new column is present and queryable, and 510 saved search assets are indexed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps
github.com/andrewkroh/go-package-specto pick up support for package-spec 3.6.6 (go-package-spec#26).Dependency-only change — no code changes were needed.
fleetpkg-mcpbuilds its schema frompkgsql.TableSchemas(), so new columns and asset types flow through automatically.What users can expect in their database
New
groupcolumn on thepackagestable. 3.6.6 adds an optional top-levelgroupfield to integration, input, and content manifests for declaring marketplace group membership. Packages that share a value belong to the same group. Kibana owns the group's title, icon, and description; the manifest field only declares membership, and values are not validated against Kibana's group list.Note that
groupis a SQLite keyword, so it must be quoted in queries:No package in
elastic/integrationssetsgroupyet, so this column is currentlyNULLfor every row. It's in place for when packages start adopting it.Saved search assets from content packages. 3.6.6 allows content packages to ship
kibana/search/*.json. Those objects now appear inkibana_saved_objectswithasset_type = 'search', the same as saved searches from integration packages (which were already supported).No change for the rest of 3.6.6. Policy tests gained an
ignore_fieldssetting, but it lives in the package-level_dev/test/config.yml, which this database doesn't index — thepolicy_teststable is built from the per-case_dev/test/policy/test-*.ymlfiles instead. The remaining 3.6.6 changes are package-spec validation and tooling only and have no schema surface.Testing
go build ./...,go vet ./..., andgo test ./...all pass.elastic/integrationscheckout: 479 packages loaded in ~18s, the newgroupcolumn is present insqlite_masterwith its doc comment and is queryable, and 510 saved search assets are indexed.