Skip to content

EAC3-JOC MIME type should not be taken as EAC3 on Pixel Device #3257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ybai001 wants to merge 1 commit into
base: main
Choose a base branch
from
+22 −1
Open

EAC3-JOC MIME type should not be taken as EAC3 on Pixel Device #3257

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 22 additions & 1 deletion libraries/exoplayer/src/main/java/androidx/media3/exoplayer/mediacodec/MediaCodecUtil.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -378,7 +378,9 @@ public static MediaCodecProfileAndLevel getHevcBaseLayerCodecProfileAndLevel(For
public static String getAlternativeCodecMimeType(Format format) {
if (MimeTypes.AUDIO_E_AC3_JOC.equals(format.sampleMimeType)) {
// E-AC3 decoders can decode JOC streams, but in 2-D rather than 3-D.
return MimeTypes.AUDIO_E_AC3;
// Some devices (e.g. Pixel) integrate an EAC3 decoder that does not support EAC3-JOC
// stream decoding.
return supportsEac3JocFallbackDecoding() ? MimeTypes.AUDIO_E_AC3 : null;
}
if (MimeTypes.AUDIO_DTS_HD.equals(format.sampleMimeType)
|| MimeTypes.AUDIO_DTS_UHD_P2.equals(format.sampleMimeType)) {
Expand Down Expand Up @@ -419,6 +421,25 @@ public static String getAlternativeCodecMimeType(Format format) {

// Internal methods.

/**
* Returns whether the device supports decoding E-AC3 JOC streams using a standard E-AC3 decoder
* (in 2-D rather than 3-D).
*
* <p>Some devices (e.g. Pixel) have an E-AC3 decoder that cannot handle E-AC3 JOC streams at
* all, even in degraded 2-D mode.
*/
private static boolean supportsEac3JocFallbackDecoding() {
String manufacturer = Build.MANUFACTURER;
String brand = Build.BRAND;
String model = Build.MODEL;

boolean isGoogle =
"Google".equalsIgnoreCase(manufacturer) && "google".equalsIgnoreCase(brand);
boolean isPixelModel = model != null && model.startsWith("Pixel");

return !(isGoogle && isPixelModel);
}

/**
* Returns {@link MediaCodecInfo}s for the given codec {@link CodecKey} in the order given by
* {@code mediaCodecList}.
Expand Down