Repository navigation
Conversation
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
|
Update: I updated the branch against current I also noted #51232, which proposes showing the model in the list, and #38772 on |
…-footer-before-80.png
…-footer-after-80.png
…-footer-after-40.png
…hild-footer-after-80-v2.png
…hild-footer-after-40-v2.png
|
Thanks for taking a look. I have updated this PR against v2 The opened child session uses the same Verification: 432 TUI tests passed, TUI typecheck passed, and |
|
Thanks for retargeting this to The scope remains two files: reuse the main prompt's Could you please confirm whether this footer placement fits the intended design and review the implementation when convenient? Thank you. |
|
One additional demand signal: #57366 independently requests the same opened-child-session bottom-bar model and reasoning-effort display. The triage bot linked it to #50795 and this PR. The TUI portion is covered by this implementation; the Desktop mention would need separate confirmation. All four checks on the current head are now passing. The scope remains the shared main-prompt metadata presentation in the opened child session. I would appreciate confirmation of the footer placement and a review when convenient. Thank you! |
|
Synced this with current The full TUI suite passes (1,559 passed, 2 skipped), along with repository lint/typechecks and the official TUI TypeScript check. I also replaced the fixture-only screenshots with real TUI captures against an isolated server using API-created demo sessions; the description notes that no external model/delegation run was involved. When you have time, could you confirm whether this footer placement fits the intended V2 design? Happy to adjust it. Thank you for reviewing! |
Issue for this PR
Closes #50795
Type of change
What does this PR do?
After opening a subagent's child session, show its persisted model and variant in the composer footer. Reuse the main prompt's
PromptMetadataRowand the model/provider catalog at the child's location. Default variants are omitted; unavailable models use their persisted ID; children without a model do not borrow the parent's model. Subagents list rows are unchanged.Synced with
devatc11a32ff1(V2 2.1.4) on 2026-10-27. The implementation and tests remain limited to two files. This uses the V2 composer path; #38772 targeted the legacy V1 footer. I would appreciate confirmation of the footer placement and design.How did you verify your code works?
Validation on 2026-10-27 with Bun 1.4.4:
packages/tuisuite (bun run test): 1,559 passed, 2 skipped, 0 failed, across 186 files.--rerun-each 10.bun run check: lint and all 35 package typecheck tasks passed.packages/tuiofficialbun run typecheck:tscalso passed.high, default variants and 80/40-column rendering. These are API-created demo sessions; no external model request or live agent delegation was performed.Screenshots / recordings
Current real-server TUI captures (2026-10-27):
Opened child with its own model and
high, 80 columns:Default variant omitted; shared metadata layout condenses at 40 columns:
Unavailable model uses the child's persisted ID:
Visual
Checklist