Repository navigation
Conversation
Set HttpOnly and (on HTTPS requests) Secure on the mskAuthorization cookie in sign-in, sign-out and the filter's cookie reset. Sum per-entry-point request counts as long and clamp to int, keeping the NowRunningAPI signature. Resolves code scanning alerts #60-#64. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mskAuthorizationcookie carries encrypted user credentials. It is nowHttpOnly, andSecurewhenever the request came over HTTPS. Secure is not forced, because MoSKito Inspect is often served over plain HTTP internally. The flags are set everywhere the cookie is written:SignInAction,SignOutActionand theMoskitoUIFilterreset. No JS reads this cookie.EntryPointRepository.getNowRunningCount()added uplongcounts into anint. It now sums into alongand clamps the result toint. TheNowRunningAPIsignature (remote API) stays the same.The remaining alerts (#17, #65–#67, stale vendored-JS alerts) are dismissed or cleaned up separately; they need no code change.
Test plan
moskito-coreandmoskito-webuicompile🤖 Generated with Claude Code