fix(array): respect negative step in range() to avoid an infinite loop - #57
Open
yfwmaniish wants to merge 1 commit into
Open
fix(array): respect negative step in range() to avoid an infinite loop#57yfwmaniish wants to merge 1 commit into
yfwmaniish wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
Closes #49.
range(start, stop, step)loops forever whenstepis negative, because the loop condition is hard-coded to the positive direction:Fix
Advance in the step's direction, so a negative step counts down and simply produces an empty array when the direction can't reach
stop:Behavior
range(1, 5, -1)[]range(5, 1, -1)[5, 4, 3, 2]range(10, 2, -2)[10, 8, 6, 4]range(2, 10, 2)[2, 4, 6, 8][2, 4, 6, 8](unchanged)range(5)/range(2, 5)Positive-step and zero-step behavior is unchanged; negative steps now count down (matching the intuitive/Python-like semantics) instead of hanging.
Tests
Extended the
rangetest with the reporter's case and descending ranges. Full suite passes (39 passed), lint clean.