Skip to content

Fix duplicate rules on init firewall #56621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
respawned86 wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −4
Open

Fix duplicate rules on init firewall #56621

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions .devcontainer/init-firewall.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,8 +59,10 @@ while read -r cidr; do
echo "ERROR: Invalid CIDR range from GitHub meta: $cidr"
exit 1
fi
echo "Adding GitHub range $cidr"
ipset add allowed-domains "$cidr"
if ! ipset test allowed-domains "$cidr" >/dev/null 2>&1; then
echo "Adding GitHub range $cidr"
ipset add allowed-domains "$cidr"
fi
done < <(echo "$gh_ranges" | jq -r '(.web + .api + .git)[]' | aggregate -q)

# Resolve and add other allowed domains
Expand All @@ -85,8 +87,10 @@ for domain in \
echo "ERROR: Invalid IP from DNS for $domain: $ip"
exit 1
fi
echo "Adding $ip for $domain"
ipset add allowed-domains "$ip"
if ! ipset test allowed-domains "$ip" >/dev/null 2>&1; then
echo "Adding $ip for $domain"
ipset add allowed-domains "$ip"
fi
done < <(echo "$ips")
done

Expand Down