Repository navigation
fix(como_cmaes): reject constrained problems instead of ignoring constraints - #810
Open
sean-from-japan wants to merge 1 commit into
Open
sean-from-japan wants to merge 1 commit into
sean-from-japan wants to merge 1 commit into
Conversation
…traints comocma is only told F, so G/H were silently ignored and every returned solution was reported with CV = 0 (e.g. all solutions infeasible on TNK and OSY). Raise a ValueError in _setup, like MOEAD, DNSGA2 and KGB do, and add a regression test.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #809
Changes
COMOCMAES._setupnow raises aValueErrorfor constrained problems, next to the existing bi-objective check. This followsMOEAD,DNSGA2andKGB, which reject constrained problems the same way.test_como_cmaes_rejects_constrained_problems.Testing
pytest tests/algorithms/test_como_cmaes.py tests/algorithms/test_mocmaes.py: 8 passed.ruff checkorruff format --checkfindings.