Keep DualStatsManager as a try/except import as it is soon going to be removed#65676
Merged
Keep DualStatsManager as a try/except import as it is soon going to be removed#65676
Conversation
boring-cyborg
Bot
added
area:providers
provider:edge
1 task
ashb
added
the
changelog:skip
shahar1
approved these changes
Apr 22, 2026
uranusjr
reviewed
Apr 22, 2026
ephraimbuddy
approved these changes
Apr 22, 2026
…e removed We are actively working on removing the DualStats manager, as other than uses cases like this introduced in #65472 it is not publicly used, so by keeping it as a try/except it means we are free to remove it at our whim.
ashb
force-pushed
the
no-dualstats-behind-version-check
branch
from
b981a0d to
3c5b681
Compare
|
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
Contributor
|
Thanks for fixing prior providers-wave, with this we have no direct version dependency and remove DualStans manager. Did not notice that Edge3 was not released (yet). (plus congrats for your first PR 8-) ) |
59 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are actively working on removing the DualStats manager in #63932, as other than uses cases like this introduced in #65472 it is not publicly used, so by keeping it as a try/except it means we are free to remove it at our whim.