-
Notifications
You must be signed in to change notification settings - Fork 16.9k
Honor AUTH_ROLE_PUBLIC in FastAPI API server #65685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
gaurav0107
wants to merge
8
commits into
apache:main
Choose a base branch
from
gaurav0107:fix/60897-auth-role-public-login
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
aefa5ea
Honor AUTH_ROLE_PUBLIC in FastAPI API server
gaurav0107 6041356
Refactor AUTH_ROLE_PUBLIC support to use middleware pattern
gaurav0107 d69a963
Address maintainer review: simpler user construction and middleware w…
gaurav0107 c6d7c85
Merge branch 'main' into fix/60897-auth-role-public-login
gaurav0107 79d88c4
Merge branch 'main' into fix/60897-auth-role-public-login
gaurav0107 7927edf
Drop provider-specific reference from base auth manager docstring
gaurav0107 445637e
Merge branch 'main' into fix/60897-auth-role-public-login
gaurav0107 33a1968
Fix mypy errors in get_fastapi_middlewares signature and FAB middleware
gaurav0107 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
57 changes: 57 additions & 0 deletions
57
providers/fab/src/airflow/providers/fab/auth_manager/middleware.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,57 @@ | ||
| # Licensed to the Apache Software Foundation (ASF) under one | ||
| # or more contributor license agreements. See the NOTICE file | ||
| # distributed with this work for additional information | ||
| # regarding copyright ownership. The ASF licenses this file | ||
| # to you under the Apache License, Version 2.0 (the | ||
| # "License"); you may not use this file except in compliance | ||
| # with the License. You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, | ||
| # software distributed under the License is distributed on an | ||
| # "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| # KIND, either express or implied. See the License for the | ||
| # specific language governing permissions and limitations | ||
| # under the License. | ||
|
|
||
| from __future__ import annotations | ||
|
|
||
| from typing import TYPE_CHECKING, cast | ||
|
|
||
| from starlette.middleware.base import BaseHTTPMiddleware | ||
|
|
||
| from airflow.api_fastapi.app import get_auth_manager | ||
| from airflow.api_fastapi.auth.managers.base_auth_manager import COOKIE_NAME_JWT_TOKEN | ||
|
|
||
| if TYPE_CHECKING: | ||
| from fastapi import Request | ||
|
|
||
| from airflow.providers.fab.auth_manager.fab_auth_manager import FabAuthManager | ||
|
|
||
|
|
||
| class FabAuthRolePublicMiddleware(BaseHTTPMiddleware): | ||
| """ | ||
| Attach an anonymous user to unauthenticated requests when public access is enabled. | ||
|
|
||
| When ``[fab] auth_role_public`` (or the legacy ``AUTH_ROLE_PUBLIC`` entry in | ||
| ``webserver_config.py``) is set, requests that do not carry any authentication | ||
| token get a pre-populated :class:`AnonymousUser` assigned to | ||
| ``request.state.user``. The FastAPI ``get_user`` dependency picks it up before | ||
| attempting JWT validation, which would otherwise reject the request with 401. | ||
| """ | ||
|
|
||
| async def dispatch(self, request: Request, call_next): | ||
| if not self._has_auth_token(request): | ||
| auth_manager = cast("FabAuthManager", get_auth_manager()) | ||
| public_user = auth_manager.build_public_user() | ||
| if public_user is not None: | ||
| request.state.user = public_user | ||
| return await call_next(request) | ||
|
|
||
| @staticmethod | ||
| def _has_auth_token(request: Request) -> bool: | ||
| auth_header = request.headers.get("authorization") | ||
| if auth_header: | ||
| return True | ||
| return bool(request.cookies.get(COOKIE_NAME_JWT_TOKEN)) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.