Add multi-team lookup to secrets backends#65689
Closed
PrithviBadiga wants to merge 1 commit intoapache:mainfrom
Closed
Add multi-team lookup to secrets backends#65689PrithviBadiga wants to merge 1 commit intoapache:mainfrom
PrithviBadiga wants to merge 1 commit intoapache:mainfrom
Conversation
Contributor
|
Can you split it in 3 different PRs please? |
Contributor
Author
|
@vincbeck
Closing this combined PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds multi-team lookup support to three secrets backends:
AzureKeyVaultBackendKubernetesSecretsBackendLockboxSecretBackendThis update makes the backends:
team_nameis providedteam_nameis not providedUpdates:
{prefix}-{team_name}-{secret_id}before{prefix}-{secret_id}team_labelsupport{id_label}={secret_id},{team_label}={team_name}before falling back to unlabeled global secrets{prefix}/{team_name}/{secret_id}before{prefix}/{secret_id}Also updates unit tests and backend docs for all three providers.
Verification:
AIRFLOW_HOME=$(mktemp -d) PYTHONPATH=/Users/prith/Desktop/Codex/airflow-65682/airflow-core/src:/Users/prith/Desktop/Codex/airflow-65682/providers/cncf/kubernetes/src /Users/prith/Desktop/Codex/airflow/.venv/bin/python -m pytest /Users/prith/Desktop/Codex/airflow-65682/providers/cncf/kubernetes/tests/unit/cncf/kubernetes/secrets/test_kubernetes_secrets_backend.pyAIRFLOW_HOME=$(mktemp -d) PYTHONPATH=/Users/prith/Desktop/Codex/airflow-65682/airflow-core/src:/Users/prith/Desktop/Codex/airflow-65682/providers/microsoft/azure/src /Users/prith/Desktop/Codex/airflow/.venv/bin/python -m pytest /Users/prith/Desktop/Codex/airflow-65682/providers/microsoft/azure/tests/unit/microsoft/azure/secrets/test_key_vault.pyAIRFLOW_HOME=$(mktemp -d) PYTHONPATH=/Users/prith/Desktop/Codex/airflow-65682/airflow-core/src:/Users/prith/Desktop/Codex/airflow-65682/providers/yandex/src /Users/prith/Desktop/Codex/airflow/.venv/bin/python -m pytest /Users/prith/Desktop/Codex/airflow-65682/providers/yandex/tests/unit/yandex/secrets/test_lockbox.py/Users/prith/Desktop/Codex/airflow/.venv/bin/python -m ruff check /Users/prith/Desktop/Codex/airflow-65682/providers/microsoft/azure/src/airflow/providers/microsoft/azure/secrets/key_vault.py /Users/prith/Desktop/Codex/airflow-65682/providers/cncf/kubernetes/src/airflow/providers/cncf/kubernetes/secrets/kubernetes_secrets_backend.py /Users/prith/Desktop/Codex/airflow-65682/providers/yandex/src/airflow/providers/yandex/secrets/lockbox.py /Users/prith/Desktop/Codex/airflow-65682/providers/microsoft/azure/tests/unit/microsoft/azure/secrets/test_key_vault.py /Users/prith/Desktop/Codex/airflow-65682/providers/cncf/kubernetes/tests/unit/cncf/kubernetes/secrets/test_kubernetes_secrets_backend.py /Users/prith/Desktop/Codex/airflow-65682/providers/yandex/tests/unit/yandex/secrets/test_lockbox.py/Users/prith/Desktop/Codex/airflow/.venv/bin/python -m ruff format --check /Users/prith/Desktop/Codex/airflow-65682/providers/microsoft/azure/src/airflow/providers/microsoft/azure/secrets/key_vault.py /Users/prith/Desktop/Codex/airflow-65682/providers/cncf/kubernetes/src/airflow/providers/cncf/kubernetes/secrets/kubernetes_secrets_backend.py /Users/prith/Desktop/Codex/airflow-65682/providers/yandex/src/airflow/providers/yandex/secrets/lockbox.py /Users/prith/Desktop/Codex/airflow-65682/providers/microsoft/azure/tests/unit/microsoft/azure/secrets/test_key_vault.py /Users/prith/Desktop/Codex/airflow-65682/providers/cncf/kubernetes/tests/unit/cncf/kubernetes/secrets/test_kubernetes_secrets_backend.py /Users/prith/Desktop/Codex/airflow-65682/providers/yandex/tests/unit/yandex/secrets/test_lockbox.pyThis closes: #65682