fix(parquet/encoding): reject invalid delta length payloads#1013
Open
fallintoplace wants to merge 3 commits into
Open
fix(parquet/encoding): reject invalid delta length payloads#1013fallintoplace wants to merge 3 commits into
fallintoplace wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
The DELTA_LENGTH_BYTE_ARRAY decoder slices payload data using unchecked lengths and keeps the logical page count after decoding fewer physical values. Invalid lengths can panic, and valid nullable pages can index past the physical length table.
What changes are included in this PR?
Are these changes tested?
Yes. Focused tests cover negative and oversized lengths plus a nullable page with fewer physical values than logical positions. The full encoding and Parquet file suites pass.