fix(parquet/encoding): respect declared RLE payload lengths#1015
Open
fallintoplace wants to merge 2 commits into
Open
fix(parquet/encoding): respect declared RLE payload lengths#1015fallintoplace wants to merge 2 commits into
fallintoplace wants to merge 2 commits into
Conversation
fallintoplace
force-pushed
the
fix/parquet-rle-payload-length
branch
from
July 25, 2026 16:12
9721f65 to
221c24c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
RLE level and boolean decoders validate their declared byte length but then give the decoder every remaining byte in the page. A short declared payload can therefore consume bytes belonging to the next encoded section instead of reporting a truncated run.
What changes are included in this PR?
Are these changes tested?
Yes. Focused tests verify that bytes after each declared RLE interval are not consumed.