fix(arrow/array): validate list-view builder dimensions#1018
Open
fallintoplace wants to merge 2 commits into
Open
fix(arrow/array): validate list-view builder dimensions#1018fallintoplace wants to merge 2 commits into
fallintoplace wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
ListViewBuilder.AppendValuesWithSizes can accept too few dimensions or ranges that do not fit within the child values. NewArray can then return an invalid ListView array that fails when read, sliced, or validated.
What changes are included in this PR?
Are these changes tested?
Yes. The tests cover missing offsets, missing sizes, negative sizes, negative offsets, and ranges beyond the child values for both offset widths. The full arrow/array package, assertion build, compute packages, IPC package, and CSV package also pass.