fix(arrow/array): ignore zero-count union appends - #1026
Merged
zeroshade merged 1 commit intoJul 27, 2026
Conversation
zeroshade
approved these changes
Jul 27, 2026
zeroshade
left a comment
Member
There was a problem hiding this comment.
Verified: `DenseUnionBuilder.AppendNulls`/`AppendEmptyValues` called the child builder once outside the count loop, so a zero count appended no union entry but still advanced the child — I reproduced parent length 0 with child length 1. The `n <= 0` guard is the right fix and brings Dense in line with `SparseUnionBuilder`, which already no-ops on a zero count. LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
DenseUnionBuilder.AppendNulls(0) and AppendEmptyValues(0) still append a child value even though they add no union entries. That hidden mutation shifts the offset of the next real value and leaves inaccessible child data behind.
What changes are included in this PR?
Are these changes tested?
Yes. The regression test verifies that both zero-count calls leave the union and child builders empty, then confirms the next real value uses offset zero. The full arrow/array package, assertion build, compute packages, and IPC package also pass.