fix(arrow/tensor): default nil dimension names to empty strings#999
Open
fallintoplace wants to merge 1 commit into
Open
fix(arrow/tensor): default nil dimension names to empty strings#999fallintoplace wants to merge 1 commit into
fallintoplace wants to merge 1 commit into
Conversation
fallintoplace
changed the title
fallintoplace
changed the title
fallintoplace
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tensor constructors document that
nildimension names are treated as empty strings, but the shared constructor left the slice nil. That makesDimNamepanic on an otherwise valid tensor.This fills in one empty name per dimension and adds coverage for both
DimNamesandDimName.Tests:
go test ./arrow/tensor