Skip to content

Add PrimitiveArray mut-or-clone helpers #9707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
alamb wants to merge 3 commits into
base: main
Choose a base branch
from
+567 −27
Draft

Add PrimitiveArray mut-or-clone helpers #9707

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f288169
[arrow-array]: add PrimitiveArray mut-or-clone helpers
alamb Apr 13, 2026
fe1f49f
fmt
alamb Apr 14, 2026
3731d89
Merge branch 'main' into alamb/primitive-array-mut-or-clone
alamb Apr 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 3 additions & 14 deletions arrow-arith/src/arity.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,17 +121,7 @@ where
if a.is_empty() {
return Ok(PrimitiveArray::from(ArrayData::new_empty(&O::DATA_TYPE)));
}

let nulls = NullBuffer::union(a.logical_nulls().as_ref(), b.logical_nulls().as_ref());

let values = a
.values()
.into_iter()
.zip(b.values())
.map(|(l, r)| op(*l, *r));

let buffer: Vec<_> = values.collect();
Ok(PrimitiveArray::new(buffer.into(), nulls))
Ok(a.binary(b, op))
}

/// Applies a binary and infallible function to values in two arrays, replacing
Expand Down Expand Up @@ -268,11 +258,10 @@ where
if a.is_empty() {
return Ok(PrimitiveArray::from(ArrayData::new_empty(&O::DATA_TYPE)));
}
let len = a.len();

if a.null_count() == 0 && b.null_count() == 0 {
try_binary_no_nulls(len, a, b, op)
try_binary_no_nulls(a.len(), a, b, op)
} else {
let len = a.len();
let nulls =
NullBuffer::union(a.logical_nulls().as_ref(), b.logical_nulls().as_ref()).unwrap();

Expand Down
Loading
Loading