Remove redundant benchmarks in cast_kernels#9789
Conversation
55fa12a to
580a1e1
Compare
cast_kernels
|
run benchmark cast_kernels |
|
🤖 Arrow criterion benchmark running (GKE) | trigger CPU Details (lscpu)Comparing alamb/prune-cast-benchmarks (580a1e1) to 9a2b49c (merge-base) diff File an issue against this benchmark runner |
scovich
left a comment
There was a problem hiding this comment.
LGTM, always nice to see a PR that reduces code size 🎉
|
🤖 Arrow criterion benchmark completed (GKE) | trigger Instance: CPU Details (lscpu)Details
Resource Usagebase (merge-base)
branch
File an issue against this benchmark runner |
Which issue does this PR close?
Rationale for this change
#9729, added many new cases to
cast_kernelsbut many of these are redundant and increase the benchmark runtime without providing proportional value in coverage.This PR reduces the redundancy by:
i128vsi256storage).decimal128to every integer width whenint64is sufficient).What changes are included in this PR?
arrow/benches/cast_kernels.rs.create_primitive_array_rangehelper toarrow/src/util/bench_util.rsCompared to main before PR #9729, the following benchmarks will be new after my PR #9789 is merged:
These cases cover the core performance paths for casting to and from decimals using representative physical storage types (i128 and i256):
Are these changes tested?
CI covers verification.
Are there any user-facing changes?
No.