ATLAS-5326: Enforce Atlas authorization on AdminResource REST endpoints#675
Open
rkundam wants to merge 1 commit into
Open
ATLAS-5326: Enforce Atlas authorization on AdminResource REST endpoints#675rkundam wants to merge 1 commit into
rkundam wants to merge 1 commit into
Conversation
| public Response getUserProfile(@Context HttpServletRequest request) throws AtlasBaseException { | ||
| LOG.debug("==> AdminResource.getUserProfile()"); | ||
|
|
||
| AtlasAuthorizationUtils.verifyAccess(new AtlasEntityAccessRequest(typeRegistry, AtlasPrivilege.ENTITY_READ), "session"); |
Collaborator
There was a problem hiding this comment.
Please remove this authz check, because this endpoint only outputs only authenticated user's information and not entity or type related information.
| @Produces(Servlets.JSON_MEDIA_TYPE) | ||
| public Set<String> getActiveSearches() { | ||
| public Set<String> getActiveSearches() throws AtlasBaseException { | ||
| AtlasAuthorizationUtils.verifyAccess(new AtlasAdminAccessRequest(AtlasPrivilege.ADMIN_EXPORT), "active searches"); |
Collaborator
There was a problem hiding this comment.
Please remove this authz, this returns only authenticated user's search Ids( threadId's) and do not expose other information.
| @Produces(Servlets.JSON_MEDIA_TYPE) | ||
| public boolean terminateActiveSearch(@PathParam("id") String searchId) { | ||
| public boolean terminateActiveSearch(@PathParam("id") String searchId) throws AtlasBaseException { | ||
| AtlasAuthorizationUtils.verifyAccess(new AtlasAdminAccessRequest(AtlasPrivilege.ADMIN_EXPORT), "terminate active search"); |
Collaborator
There was a problem hiding this comment.
Please remove this authz. Search do not have authz. if authz added here. The user can make search calls but not able to terminate the search Rest.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
AtlasAuthorizationUtils.verifyAccess()to sensitiveAdminResourceREST endpoints that previously lacked Atlas-level authorization checks./version,/status,/metrics,/metricsstats*,/liveness,/readiness) accessible to any authenticated user without an additional Atlas privilege check.Changes
ADMIN_EXPORT,ADMIN_IMPORT,ADMIN_PURGE,ADMIN_AUDITS,ENTITY_READ).withAuthorizationBypass/withAuthorizationBypassCallabletest helpers and update unit tests for protected vs. open endpoints.Protected endpoints
Intentionally unprotected (authentication only)
How was this patch tested?
Manual testing