Skip to content

Add connectivity type tracking to endpoint consumption logic#38249

Open
parveensania wants to merge 2 commits intoapache:masterfrom
parveensania:fb-consume-connectivity-type
Open

Add connectivity type tracking to endpoint consumption logic#38249
parveensania wants to merge 2 commits intoapache:masterfrom
parveensania:fb-consume-connectivity-type

Conversation

@parveensania
Copy link
Copy Markdown
Contributor

This PR updates the endpoint consumption logic in FanOutStreamingEngineWorkerHarness to trigger refreshes whenever the connectivity type changes, even if the metadata version remains the same.

Previously, the harness only refreshed endpoints if the metadata version increased. This change ensures the client immediately picks new endpoint types if backend settings change, without waiting for a version increment.

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the endpoint consumption logic within the streaming engine harness to be more responsive to backend connectivity changes. By tracking the connectivity type alongside the metadata version, the system can now proactively refresh endpoints when backend settings change, ensuring better connectivity management without relying solely on metadata version increments.

Highlights

  • Connectivity Type Tracking: Introduced a new 'Type' enum in WindmillEndpoints to track connectivity types (e.g., CLOUDPATH, BORG, DIRECTPATH) and updated the endpoint consumption logic to trigger refreshes when this type changes, even if the metadata version remains the same.
  • Refreshed Consumption Logic: Modified FanOutStreamingEngineWorkerHarness to track the active metadata type and ensure that endpoint updates are processed if either the version increases or the connectivity type changes.
  • Stream Metadata Handling: Updated GrpcGetWorkerMetadataStream to remove the stale metadata check, allowing the harness to handle all incoming metadata updates and determine if they should be consumed based on the new logic.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@github-actions
Copy link
Copy Markdown
Contributor

Assigning reviewers:

R: @tvalentyn added as fallback since no labels match configuration

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

// The endpoints are also consumed if the version is the same but the type of endpoints
// sent by the server has changed.
if (windmillEndpoints.version() > pendingMetadataVersion
|| (windmillEndpoints.version() == pendingMetadataVersion
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need this version check? Seems like it is enough to check if metadata changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants