Add connectivity type tracking to endpoint consumption logic#38249
Add connectivity type tracking to endpoint consumption logic#38249parveensania wants to merge 2 commits intoapache:masterfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the endpoint consumption logic within the streaming engine harness to be more responsive to backend connectivity changes. By tracking the connectivity type alongside the metadata version, the system can now proactively refresh endpoints when backend settings change, ensuring better connectivity management without relying solely on metadata version increments. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
|
Assigning reviewers: R: @tvalentyn added as fallback since no labels match configuration Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
| // The endpoints are also consumed if the version is the same but the type of endpoints | ||
| // sent by the server has changed. | ||
| if (windmillEndpoints.version() > pendingMetadataVersion | ||
| || (windmillEndpoints.version() == pendingMetadataVersion |
There was a problem hiding this comment.
do we need this version check? Seems like it is enough to check if metadata changed.
This PR updates the endpoint consumption logic in FanOutStreamingEngineWorkerHarness to trigger refreshes whenever the connectivity type changes, even if the metadata version remains the same.
Previously, the harness only refreshed endpoints if the metadata version increased. This change ensures the client immediately picks new endpoint types if backend settings change, without waiting for a version increment.