Skip to content

fix pipeline result naming inconsistency in Dataflow runner #38254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Subramanya-Veeregowda wants to merge 4 commits into
base: master
Choose a base branch
from
+15 −0
Open

fix pipeline result naming inconsistency in Dataflow runner #38254

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5182aec
fix pipeline result naming in Dataflow runner
Subramanya-Veeregowda Apr 21, 2026
3570b25
Address review feedback: simplify Pipelineresult docs
Subramanya-Veeregowda Apr 21, 2026
3a085a3
Trigger CI
Subramanya-Veeregowda Apr 22, 2026
52fac93
Re trigger CI
Subramanya-Veeregowda Apr 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions ...oud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/DataflowPipelineJob.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,11 @@
"nullness", // TODO(https://github.com/apache/beam/issues/20497)
"Slf4jDoNotLogMessageOfExceptionExplicitly", // intended, sent full stacktrace to LOG.debug
})
/**
* Dataflow implementation of {@link PipelineResult}.
*
* <p>Note: This class represents a PipelineResult but uses a different name for historical reasons.
*/
public class DataflowPipelineJob implements PipelineResult {

private static final Logger LOG = LoggerFactory.getLogger(DataflowPipelineJob.class);
Expand Down
10 changes: 10 additions & 0 deletions sdks/java/core/src/main/java/org/apache/beam/sdk/PipelineResult.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,16 @@
* Result of {@link Pipeline#run()}.
*
* <p>This is often a job handle to an underlying data processing engine.
*
* <ul>
* <li>Dataflow: {@code DataflowPipelineJob}
* <li>Flink: {@code FlinkRunnerResult}
* <li>Spark: {@code EvaluationContext}
* <li>DirectRunner: {@code DirectPipelineResult}
* </ul>
*
* <p>All of the above represent implementations of {@link PipelineResult}, even if their names do
* not explicitly include "PipelineResult".
*/
public interface PipelineResult {

Expand Down
Loading