Add DiskProvisionedIops/ThroughputMibps pipeline options for the Python SDK#38368
Add DiskProvisionedIops/ThroughputMibps pipeline options for the Python SDK#38368bambadiouf1 wants to merge 8 commits intoapache:masterfrom
Conversation
…ns to pipeline configuration
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enables fine-grained control over worker disk performance for Google Cloud Dataflow pipelines. By introducing new pipeline options for provisioned IOPS and throughput, users can now optimize their worker VM disk performance based on specific workload requirements. The changes span the Python, Java, and Go SDKs, ensuring consistent behavior and validation across the supported environments. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces support for configuring disk provisioned IOPS and throughput for Dataflow workers across the Java, Go, and Python SDKs. It includes updates to pipeline options, translator logic, and corresponding unit tests for each SDK. Additionally, it updates the Dataflow API client versions and includes minor dependency updates and formatting fixes in the Go SDK. Feedback was provided to update the release notes to include Python support and use more general language for the new pipeline options.
|
|
||
| ## New Features / Improvements | ||
|
|
||
| * Added support for setting disk provisioned IOPS and throughput in Dataflow runner via `--diskProvisionedIops` and `--diskProvisionedThroughputMibps` pipeline options (Java/Go) ([#38349](https://github.com/apache/beam/issues/38349)). |
There was a problem hiding this comment.
The entry mentions support for Java and Go, but this pull request also adds support for the Python SDK. Additionally, the flag names for Python and Go use snake_case (--disk_provisioned_iops and --disk_provisioned_throughput_mibps) rather than the camelCase shown. Consider updating the description to include Python and use more general language for the option names to cover all SDKs.
| * Added support for setting disk provisioned IOPS and throughput in Dataflow runner via `--diskProvisionedIops` and `--diskProvisionedThroughputMibps` pipeline options (Java/Go) ([#38349](https://github.com/apache/beam/issues/38349)). | |
| * Added support for setting disk provisioned IOPS and throughput in Dataflow runner via disk provisioned IOPS and throughput pipeline options (Java/Go/Python) ([#38349](https://github.com/apache/beam/issues/38349)). |
|
Assigning reviewers: R: @shunping for label python. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
This pull request introduces two new pipeline options for the Google Cloud Dataflow runner for the python SDK. These options allow users to specify provisioned performance for worker VM disks:
disk_provisioned_iops: Sets the provisioned IOPS for the disk. If unspecified, the service chooses a default
disk_provisioned_throughput_mibps: Sets the provisioned throughput in MiB/s for the disk.
Tests have been added/updated to verify that these options are correctly parsed and translated.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.