Skip to content

[CALCITE-7604] Add rule to pull up GROUP BY above JOIN#5029

Merged
zabetak merged 1 commit into
apache:mainfrom
zabetak:CALCITE-7604-02
Jun 24, 2026
Merged

[CALCITE-7604] Add rule to pull up GROUP BY above JOIN#5029
zabetak merged 1 commit into
apache:mainfrom
zabetak:CALCITE-7604-02

Conversation

@zabetak

@zabetak zabetak commented Jun 19, 2026

Copy link
Copy Markdown
Member

Jira Link

CALCITE-7604

Changes Proposed

  1. Add JoinAggregateTransposeRule to pull up GROUP BY above JOIN
  2. Add test cases for the rule showcasing the effects on the most common cases

mihaibudiu
mihaibudiu reviewed Jun 20, 2026
View reviewed changes
Comment thread core/src/main/java/org/apache/calcite/rel/rules/JoinAggregateTransposeRule.java
Comment thread core/src/main/java/org/apache/calcite/rel/rules/JoinAggregateTransposeRule.java Outdated
Comment thread core/src/test/resources/org/apache/calcite/test/JoinAggregateTransposeRuleTest.xml Outdated
xiedeyantu
xiedeyantu reviewed Jun 20, 2026
View reviewed changes
Comment thread core/src/main/java/org/apache/calcite/rel/rules/JoinAggregateTransposeRule.java
Comment thread core/src/main/java/org/apache/calcite/rel/rules/JoinAggregateTransposeRule.java Outdated
Comment thread core/src/main/java/org/apache/calcite/rel/rules/JoinAggregateTransposeRule.java Outdated
@zabetak

zabetak commented Jun 24, 2026

Copy link
Copy Markdown
Member Author

I rebased and squashed the commits together. I will merge this once tests pass!

@sonarqubecloud

sonarqubecloud Bot commented Jun 24, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
96.6% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@zabetak zabetak merged commit 0e10a48 into apache:main Jun 24, 2026
19 checks passed
@zabetak zabetak deleted the CALCITE-7604-02 branch June 24, 2026 12:57
@zabetak

zabetak commented Jun 24, 2026

Copy link
Copy Markdown
Member Author

Thanks for the reviews @mihaibudiu @rubenada @xiedeyantu @xuzifu666

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mihaibudiu mihaibudiu mihaibudiu left review comments
@xuzifu666 xuzifu666 xuzifu666 approved these changes
@rubenada rubenada rubenada approved these changes
@xiedeyantu xiedeyantu xiedeyantu approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@zabetak @xuzifu666 @mihaibudiu @rubenada @xiedeyantu