[CALCITE-6027] Simplify the cardinality on map_keys and map_values functions#5037
Open
xuzifu666 wants to merge 1 commit into
Open
[CALCITE-6027] Simplify the cardinality on map_keys and map_values functions#5037xuzifu666 wants to merge 1 commit into
xuzifu666 wants to merge 1 commit into
Conversation
|
mihaibudiu
reviewed
Jun 22, 2026
|
|
||
| // Simplify CARDINALITY(MAP_KEYS(m)) -> CARDINALITY(m) | ||
| // and CARDINALITY(MAP_VALUES(m)) -> CARDINALITY(m) | ||
| if (e.getOperator().getName().equals("CARDINALITY") |
Contributor
There was a problem hiding this comment.
Do you expect people write such programs?
There's potentially an infinite number of such optimizations we can consider, but are they useful in practice?
Member
Author
There was a problem hiding this comment.
You are right. This is indeed an overly restrictive optimization, with little value; I currently share this view. Perhaps the value of Jira needs further discussion.
Member
Author
There was a problem hiding this comment.
I had moved the discussion to jira.
xuzifu666
added
the
discussion-in-jira
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
jira: https://issues.apache.org/jira/browse/CALCITE-6027