adjustments to clarify the README - CASSSIDECAR-488 - #373
Open
aar0np wants to merge 2 commits into
Open
Conversation
yifan-c
reviewed
Aug 4, 2026
| ./scripts/build-dtest-jars.sh | ||
| ``` | ||
|
|
||
| The build script supports two parameters: |
Contributor
There was a problem hiding this comment.
after moving this script to the bottom of the section, "The build script" can read confusing.
Author
There was a problem hiding this comment.
Got it. Adding an extra sentence to clarify that.
yifan-c
reviewed
Aug 4, 2026
Comment on lines
-59
to
84
| ### macOS network aliases | ||
| To get up and running, create a temporary alias for every node except the first: | ||
|
|
||
| ``` | ||
| for i in {2..20}; do sudo ifconfig lo0 alias "127.0.0.${i}"; done | ||
| ``` | ||
|
|
||
| Note that this does not persist across reboots, so you'll have to run it every time you restart. |
Contributor
There was a problem hiding this comment.
This is specifically required for macOS only.
Author
There was a problem hiding this comment.
That "macOS network aliases" header is still there, it's just a little higher up.
yifan-c
reviewed
Aug 4, 2026
Comment on lines
72
to
77
| ### macOS network aliases | ||
|
|
||
| For multi-node in-jvm dtests, network aliases will need to be setup for each Cassandra node. The tests assume each node's ip address is 127.0.0.x, where x is the node id. | ||
|
|
||
| For example if you populated your cluster with 3 nodes, create interfaces for 127.0.0.2 and 127.0.0.3 (the first node of course uses 127.0.0.1). | ||
|
|
Contributor
There was a problem hiding this comment.
Those 2 paragraphs are common and should not be under macOS network aliases
Author
There was a problem hiding this comment.
Oh...I see what you mean. Let me move those two paragraphs ABOVE the "macOS network aliases" header like it was before.
Author
|
Ok, corrections made. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per CASSSIDECAR-488: