-
Notifications
You must be signed in to change notification settings - Fork 447
[CELEBORN-2336] Support decommission shutdown for worker scale-down scenarios #3698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 1 commit
9bc9eb1
ad76e88
c8227df
81d825b
df73277
4cd9d6b
d5ff48c
abc0013
a5ac067
c604d25
de748dd
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -1081,6 +1081,9 @@ private[celeborn] class Worker( | |
| case WorkerEventType.Graceful => | ||
| shutdownGracefully() | ||
| case WorkerEventType.Decommission => | ||
| ShutdownHookManager.get().updateTimeout( | ||
| conf.workerDecommissionForceExitTimeout, | ||
| TimeUnit.MILLISECONDS) | ||
| decommissionWorker() | ||
|
chenghuichen marked this conversation as resolved.
Outdated
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Decommission report failure has no retry/fallback on the SIGTERM path. |
||
| case _ => | ||
| exitImmediately() | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -39,8 +39,13 @@ private[celeborn] class WorkerStatusManager(conf: CelebornConf) extends Logging | |
| private var worker: Worker = _ | ||
| private var shutdown: AtomicBoolean = _ | ||
| private var storageManager: StorageManager = _ | ||
| private val decommissionShutdown = conf.workerDecommissionShutdown | ||
| private val gracefulShutdown = conf.workerGracefulShutdown | ||
| if (gracefulShutdown) { | ||
| if (decommissionShutdown) { | ||
| exitEventType = WorkerEventType.Decommission | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
| logInfo("Decommission shutdown enabled, worker will decommission on SIGTERM" + | ||
| " (overrides graceful shutdown)") | ||
| } else if (gracefulShutdown) { | ||
| exitEventType = WorkerEventType.Graceful | ||
| } | ||
|
chenghuichen marked this conversation as resolved.
|
||
|
|
||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.