[CELEBORN-2370] Scope reducer metadata by partition range#3745
Open
sunchao wants to merge 2 commits into
Open
Conversation
Contributor
|
I'll take a look at this soon. It's an interesting PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA: CELEBORN-2370
Supersedes #3687.
Why are the changes needed?
Before a Spark reducer can read shuffle data, Celeborn calls
GetReducerFileGroupto obtain reducer file locations and related metadata.Today that response is shuffle-wide. For a shuffle with
Nreducers, it contains metadata for allNreducers, even though a Spark task normally reads only[startPartition, endPartition).For example:
[42, 43); butThe response is cached independently on every executor, so metadata transfer and executor memory grow with the total reducer count multiplied by the number of executors, rather than with the reducer ranges those executors actually read. On very large shuffles this can cause:
The driver still needs to retain complete shuffle commit metadata. This PR reduces the metadata transferred to and cached by each executor.
What changes were proposed in this pull request?
Add optional partition-range fields to
GetReducerFileGrouprequests and responses.When Spark reads a shuffle:
[startPartition, endPartition)range.The executor cache also:
Partition-scoped responses bypass the existing shuffle-wide RPC cache and Spark broadcast path. Legacy full-shuffle requests continue to use the existing cache and broadcast behavior.
This PR changes the Spark client and the Spark driver-side lifecycle/commit endpoint. It does not change the Celeborn Master or Worker.
Does this PR introduce any user-facing change?
No configuration or public API change is required.
When both the Spark client and driver contain this change, reducer metadata transfer and executor cache size become proportional to the partition ranges read by that executor instead of the total reducer count.
The wire protocol remains backward compatible:
Mixed-version deployments remain correct, but the optimization applies only when the driver supports scoped responses.
How was this patch tested?
ShuffleClientSuiteJ: 29 tests covering range caching, concurrent loads, cleanup races, interruption, and old-driver fallbackUtilsSuite: 28 tests, including V1 and V2 protocol round tripsReducerFileGroupFilterSuite: 2 range-filtering testsConfigurationSuite: 8 testsCelebornHashSuiteandCelebornSortSuite(4 tests)