Skip to content

[EMAIL-208] Updated the default sslCheckServerIdentity value #393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Nocera60 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[EMAIL-208] Updated the default sslCheckServerIdentity value #393

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions commons-email2-jakarta/src/main/java/org/apache/commons/mail2/jakarta/Email.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,9 +221,9 @@ public abstract class Email {

/**
* If set to true, check the server identity as specified by RFC 2595. These additional checks based on the content of the server's certificate are intended
* to prevent man-in-the-middle attacks. Defaults to false.

@Trustinbtc999-hue Trustinbtc999-hue Jun 5, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do I fix this?

* to prevent man-in-the-middle attacks. Defaults to true.
*/
private boolean sslCheckServerIdentity;
private boolean sslCheckServerIdentity = true;

/**
* If set to true, and a message has some valid and some invalid addresses, send the message anyway, reporting the partial failure with a
Expand Down Expand Up @@ -830,8 +830,8 @@ public Session getMailSession() throws EmailException {
properties.setProperty(EmailConstants.MAIL_SMTP_SOCKET_FACTORY_FALLBACK, "false");
}

if ((isSSLOnConnect() || isStartTLSEnabled()) && isSSLCheckServerIdentity()) {

@Trustinbtc999-hue Trustinbtc999-hue Jun 5, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's going on with this?

properties.setProperty(EmailConstants.MAIL_SMTP_SSL_CHECKSERVERIDENTITY, "true");
if (isSSLOnConnect() || isStartTLSEnabled()) {
properties.setProperty(EmailConstants.MAIL_SMTP_SSL_CHECKSERVERIDENTITY, String.valueOf(isSSLCheckServerIdentity()));
}

if (bounceAddress != null) {
Expand Down