Skip to content

chore(deps): Update testing/coverage deps#989

Merged
dpogue merged 3 commits into
apache:masterfrom
dpogue:deps
Jun 17, 2026
Merged

chore(deps): Update testing/coverage deps#989
dpogue merged 3 commits into
apache:masterfrom
dpogue:deps

Conversation

@dpogue

@dpogue dpogue commented Jun 17, 2026

Copy link
Copy Markdown
Member

Platforms affected

All

Description

Resolves some npm audit warnings by updating to the latest versions of jasmine and c8. Overrides c8's yargs dependency version to make it work on Node 26.

Testing

Tests pass locally

Checklist

  • I've run the tests to see all new and existing tests pass

@dpogue dpogue requested a review from erisu June 17, 2026 07:53
@codecov-commenter

codecov-commenter commented Jun 17, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.73%. Comparing base (e5c554d) to head (f7bfda4).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #989      +/-   ##
==========================================
+ Coverage   89.61%   89.73%   +0.11%     
==========================================
  Files          41       41              
  Lines        5190     5192       +2     
==========================================
+ Hits         4651     4659       +8     
+ Misses        539      533       -6     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread package.json
"elementtree": "^0.1.7",
"jasmine": "^5.10.0",
"jasmine": "^6.3.0",
"jasmine-spec-reporter": "^7.0.0",

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this dependency was only used in the helper.js file that was removed in this PR, so it might be OK to remove it. Needs confirmation.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might need to restore the helper stuff, because Windows tests were timing out in my fork

@erisu erisu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dpogue dpogue merged commit 9ad4a84 into apache:master Jun 17, 2026
11 checks passed
@dpogue dpogue deleted the deps branch June 17, 2026 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants