Skip to content

[refine](code) remove dead runtime helpers and deprecated MaxCompute fields #63026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Mryange wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[refine](code) remove dead runtime helpers and deprecated MaxCompute fields #63026

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 0 additions & 23 deletions be/src/format/generic_reader.cpp
View file
Open in desktop

This file was deleted.

39 changes: 0 additions & 39 deletions be/src/runtime/collection_value.cpp
View file
Open in desktop

This file was deleted.

13 changes: 0 additions & 13 deletions be/src/runtime/collection_value.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,6 @@ class CollectionValue {
explicit CollectionValue(uint64_t length)
: _data(nullptr), _length(length), _has_null(false), _null_signs(nullptr) {}

CollectionValue(void* data, uint64_t length)
: _data(data), _length(length), _has_null(false), _null_signs(nullptr) {}

CollectionValue(void* data, uint64_t length, bool* null_signs)
: _data(data), _length(length), _has_null(true), _null_signs(null_signs) {}

Expand All @@ -49,21 +46,11 @@ class CollectionValue {

bool is_null_at(uint64_t index) const { return this->_has_null && this->_null_signs[index]; }

uint64_t size() const { return _length; }

uint64_t length() const { return _length; }

void shallow_copy(const CollectionValue* other);

void copy_null_signs(const CollectionValue* other);

const void* data() const { return _data; }
bool has_null() const { return _has_null; }
const bool* null_signs() const { return _null_signs; }
void* mutable_data() { return _data; }
bool* mutable_null_signs() { return _null_signs; }
void set_length(uint64_t length) { _length = length; }
void set_has_null(bool has_null) { _has_null = has_null; }
void set_data(void* data) { _data = data; }
void set_null_signs(bool* null_signs) { _null_signs = null_signs; }

Expand Down
7 changes: 0 additions & 7 deletions be/src/runtime/process_profile.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,13 +32,6 @@ class ProcessProfile {

void refresh_profile();

std::string print_process_profile() const {
auto version_ptr = _process_profile.get();
std::stringstream ss;
version_ptr->pretty_print(&ss);
return ss.str();
}

std::string print_process_profile_no_root() const {
std::stringstream ss;
std::vector<RuntimeProfile*> profiles;
Expand Down
12 changes: 0 additions & 12 deletions be/src/runtime/result_queue_mgr.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,16 +104,4 @@ Status ResultQueueMgr::cancel(const TUniqueId& fragment_instance_id) {
return Status::OK();
}

void ResultQueueMgr::update_queue_status(const TUniqueId& fragment_instance_id,
const Status& status) {
if (status.ok()) {
return;
}
std::lock_guard<std::mutex> l(_lock);
auto iter = _fragment_queue_map.find(fragment_instance_id);
if (iter != _fragment_queue_map.end()) {
iter->second->update_status(status);
}
}

} // namespace doris
2 changes: 0 additions & 2 deletions be/src/runtime/result_queue_mgr.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,8 +49,6 @@ class ResultQueueMgr {

Status cancel(const TUniqueId& fragment_id);

void update_queue_status(const TUniqueId& fragment_id, const Status& status);

private:
std::mutex _lock;
std::unordered_map<TUniqueId, BlockQueueSharedPtr> _fragment_queue_map;
Expand Down
23 changes: 0 additions & 23 deletions be/src/runtime/runtime_state.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,9 +112,6 @@ class RuntimeState {
Status init(const TUniqueId& fragment_instance_id, const TQueryOptions& query_options,
const TQueryGlobals& query_globals, ExecEnv* exec_env);

// for ut and non-query.
void set_exec_env(ExecEnv* exec_env) { _exec_env = exec_env; }

// for ut and non-query.
void init_mem_trackers(const std::string& name = "ut", const TUniqueId& id = TUniqueId());

Expand Down Expand Up @@ -168,7 +165,6 @@ class RuntimeState {
}

int query_parallel_instance_num() const { return _query_options.parallel_instance; }
int max_errors() const { return _query_options.max_errors; }
int execution_timeout() const {
return _query_options.__isset.execution_timeout ? _query_options.execution_timeout
: _query_options.query_timeout;
Expand Down Expand Up @@ -213,7 +209,6 @@ class RuntimeState {
TimezoneUtils::find_cctz_time_zone(_timezone, _timezone_obj);
}
const std::string& lc_time_names() const { return _lc_time_names; }
const std::string& user() const { return _user; }
const TUniqueId& query_id() const { return _query_id; }
const TUniqueId& fragment_instance_id() const { return _fragment_instance_id; }
// should only be called in pipeline engine
Expand Down Expand Up @@ -248,12 +243,6 @@ class RuntimeState {
_query_options.enable_common_expr_pushdown;
}

bool enable_common_expr_pushdown_for_inverted_index() const {
return enable_common_expr_pushdown() &&
_query_options.__isset.enable_common_expr_pushdown_for_inverted_index &&
_query_options.enable_common_expr_pushdown_for_inverted_index;
};

bool mysql_row_binary_format() const {
return _query_options.__isset.mysql_row_binary_format &&
_query_options.mysql_row_binary_format;
Expand All @@ -267,12 +256,6 @@ class RuntimeState {
// Appends error to the _error_log if there is space
bool log_error(const std::string& error);

// Returns true if the error log has not reached _max_errors.
bool log_has_space() {
std::lock_guard<std::mutex> l(_error_log_lock);
return _error_log.size() < _query_options.max_errors;
}

// Append all _error_log[_unreported_error_idx+] to new_errors and set
// _unreported_error_idx to _errors_log.size()
void get_unreported_errors(std::vector<std::string>* new_errors);
Expand Down Expand Up @@ -306,12 +289,8 @@ class RuntimeState {

const std::vector<std::string>& export_output_files() const { return _export_output_files; }

void add_export_output_file(const std::string& file) { _export_output_files.push_back(file); }

void set_db_name(const std::string& db_name) { _db_name = db_name; }

const std::string& db_name() { return _db_name; }

void set_wal_id(int64_t wal_id) { _wal_id = wal_id; }

int64_t wal_id() const { return _wal_id; }
Expand All @@ -322,8 +301,6 @@ class RuntimeState {

const std::string& import_label() { return _import_label; }

const std::string& load_dir() const { return _load_dir; }

void set_load_job_id(int64_t job_id) { _load_job_id = job_id; }

int64_t load_job_id() const { return _load_job_id; }
Expand Down
Loading