branch-4.0: [fix](filecache) reject oversized block size in add_cell #62878#63045
Open
github-actions[bot] wants to merge 1 commit intobranch-4.0from
Open
branch-4.0: [fix](filecache) reject oversized block size in add_cell #62878#63045github-actions[bot] wants to merge 1 commit intobranch-4.0from
github-actions[bot] wants to merge 1 commit intobranch-4.0from
Conversation
When directory_entry::file_size(ec) fails, it returns (uintmax_t)-1. load_cache_info_into_memory did not check ec, so UINT64_MAX flowed into add_cell, which only warned and then registered the cell — corrupting _files, LRUQueue::cache_size, _cur_cache_size, and the LRU dump (survives restart). - fs_file_cache_storage: check ec after file_size, skip on error - add_cell: turn the >1GiB check into a hard reject (return nullptr) - UT: add_cell_rejects_oversized_size
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
|
run buildall |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picked from #62878