branch-4.1: [fix](fe) Fix Ranger column-level privilege bypass when CTE combined #61741#63048
Open
github-actions[bot] wants to merge 1 commit intobranch-4.1from
Open
branch-4.1: [fix](fe) Fix Ranger column-level privilege bypass when CTE combined #61741#63048github-actions[bot] wants to merge 1 commit intobranch-4.1from
github-actions[bot] wants to merge 1 commit intobranch-4.1from
Conversation
…61741) ### What problem does this PR solve? Issue Number: close #61631 Problem Summary: When a CTE (WITH ... AS) is referenced multiple times in a JOIN query and is not inlined (due to inlineCTEReferencedThreshold), the CheckPrivileges rule does not traverse the CTE producer subtree because LogicalCTEConsumer is a leaf node in the plan tree. This means column-level privileges on the CTE's underlying tables are never checked, allowing users without proper column access to bypass Ranger authorization. The fix adds a `visitLogicalCTEConsumer` override in `CheckPrivileges` that explicitly retrieves the CTE producer plan (stored by `RewriteCteChildren`) and traverses it for privilege checking. The `privChecked` flag remains on `StatementContext` to preserve the view permission passthrough mechanism. ### Release note Fixed a security issue where Ranger column-level privileges could be bypassed when using CTE (WITH ... AS) combined with JOIN queries. Users without proper column access permissions could read restricted columns through CTE+JOIN patterns. ### Check List (For Author) - Test: Unit Test / Manual test (verified with Ranger 2.7.0 + Doris 4.0.2 environment) - Behavior changed: No - Does this need documentation: No --------- Co-authored-by: geshengli <geshengli@wps.cn>
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
|
run buildall |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picked from #61741