branch-4.0: [fix](parse) No longer throws exceptions when parse datetime failed in from_olap_string #63035#63077
Open
zclllyybb wants to merge 1 commit intoapache:branch-4.0from
Open
branch-4.0: [fix](parse) No longer throws exceptions when parse datetime failed in from_olap_string #63035#63077zclllyybb wants to merge 1 commit intoapache:branch-4.0from
zclllyybb wants to merge 1 commit intoapache:branch-4.0from
Conversation
…n from_olap_string ### What problem does this PR solve? Issue Number: None Related PR: apache#63035 Problem Summary: Backport apache#63035 to branch-4.0. SerDe from_olap_string handled invalid datelike strings inconsistently: DateV2 and DateTimeV2 filled type minimums while DateV1 and DateTimeV1 returned errors. This change makes DateV1 and DateTimeV1 fall back to datelike minimums and documents the existing DateV2 and DateTimeV2 fallback behavior. ### Release note None ### Check List (For Author) - Test: Unit Test - ./run-be-ut.sh --run --filter=OlapTypeTest.* - Behavior changed: Yes. Invalid DateV1/DateTimeV1 values passed through from_olap_string now produce the datelike minimum, matching DateV2/DateTimeV2. - Does this need documentation: No
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
zclllyybb
changed the title
Contributor
Author
|
run buildall |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aligns OLAP-string deserialization behavior for datelike types by avoiding errors/exceptions on parse failure and instead populating a type-specific minimum/default value, improving robustness when encountering legacy or placeholder zonemap values.
Changes:
- Make
TYPE_DATE/TYPE_DATETIMEfrom_olap_string()fall back toVecDateTimeValue::FIRST_DAYinstead of returningInvalidArgument. - Document and preserve the existing fallback behavior for
DATEV2/DATETIMEV2(MIN_DATE_V2/MIN_DATETIME_V2) on parse failure. - Add a BE unit test asserting default fallback behavior on invalid OLAP strings for all datelike variants.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| be/test/olap/olap_type_test.cpp | Adds a regression test validating datelike from_olap_string() parse-failure defaults. |
| be/src/vec/data_types/serde/data_type_datev2_serde.cpp | Clarifies parse-failure fallback to MIN_DATE_V2 in from_olap_string(). |
| be/src/vec/data_types/serde/data_type_datetimev2_serde.cpp | Clarifies parse-failure fallback to MIN_DATETIME_V2 in from_olap_string(). |
| be/src/vec/data_types/serde/data_type_date_or_datetime_serde.cpp | Changes DATE/DATETIME from_olap_string() to fall back to FIRST_DAY instead of erroring. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| const std::string& input, | ||
| const vectorized::Field& expected_field) { | ||
| vectorized::Field field; | ||
| vectorized::DataTypeSerDe::FormatOptions options; |
Comment on lines
405
to
409
| // set false to `is_strict`, it will not set error code cuz we dont need then speed up the process. | ||
| // then we rely on return value to check success. | ||
| // return value only represent OK or InvalidArgument for other error(like InternalError) in parser, MUST throw | ||
| // Exception! | ||
| if (!CastToDateOrDatetime::from_string_non_strict_mode<IsDatetime>( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pick #63035