-
Notifications
You must be signed in to change notification settings - Fork 2.2k
feat: Support version history and rollback for traffic rules #1477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mochengqian
wants to merge
36
commits into
apache:develop
Choose a base branch
from
mochengqian:feat/Support-version-history-and-rollback-for-traffic-rules
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 33 commits
Commits
Show all changes
36 commits
Select commit
Hold shift + click to select a range
0541218
chore(store): add ListResources + align gorm/memory empty-index seman…
mochengqian cec939e
fix(discovery): nil-guard zk rule delete + emit registry context on e…
mochengqian 366033e
feat(versioning): backend immutable release ledger for traffic rules
mochengqian 43567af
feat(versioning): UI history drawer, diff, and rollback for rule pages
mochengqian e1edfa0
test(versioning): end-to-end rollback drill
mochengqian 3e29abd
fix(versioning): close gaps surfaced by the smoke drill
mochengqian c4397fa
fix(traffic): preserve priority/force/configVersion on rule edit forms
mochengqian 10f17fd
chore: ignore local planning artifacts
mochengqian 7e59e80
fix(versioning): close owner review correctness gaps
mochengqian 65a822a
refactor(versioning): drop unused helpers and aliases
mochengqian 9596f7e
fix(ui): plug rule diff editor leaks
mochengqian ee7e603
Remove local working memory files from .gitignore
mochengqian d5f034f
fix(versioning): add intent repair and abandon flows
mochengqian f131596
Merge pull request #1 from mochengqian/feat/Support-version-history-a…
mochengqian eee253e
Revert "feat: support traffic rule version history and rollback"
mochengqian d7cd149
Merge pull request #2 from mochengqian/revert-1-feat/Support-version-…
mochengqian 6f2a8c5
fix(lock): use acquisition-scoped leases
mochengqian 438cac7
refactor(versioning): split resource store responsibilities
mochengqian e7bca60
refactor(versioning): normalize events and reduce repair APIs
mochengqian 45b3dd3
fix(lock): stop writes after lease loss
mochengqian ae52ff8
refactor(ui): remove unreachable state and simplify mocks
mochengqian 88e1420
test(versioning): add multi-instance and lease failure coverage
mochengqian 0888e4a
docs(versioning): update default-enabled guarantees
mochengqian 771a523
fix: address rule versioning review blockers
mochengqian f227c10
fix: harden rule versioning correctness
mochengqian d49f46c
fix: address rule versioning review issues
mochengqian 368ae9d
Fix rule version commit terminal semantics
mochengqian 4de011a
fix(versioning): harden rule intent recovery
mochengqian 1072ce0
fix(versioning): close intent recovery race windows
mochengqian 1ad7607
Fix rule intent storage CAS and subscriber fallback
mochengqian 53afc2c
Fix rule version committing recovery ordering
mochengqian 1e6f9cd
Fix Go CI cache restore
mochengqian aaeb108
Clean up PR-only test files
mochengqian 825f51f
docs(versioning): clarify invariants and recovery comments
mochengqian 512cd46
20 maxVersion is suitable
mochengqian 3b5f002
chore: limit rule version retention to 20
mochengqian File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里修改的原因是,PR CI 在可靠运行 Go 测试之前就已失败(CI failure 有明确日志证据,在failed check 82487011873)。
失败的 GitHub Actions 任务显示了手动 Go 模块缓存恢复时出现的 tar 恢复错误,包括:
Failed to restore: "/usr/bin/tar" failed
Cannot open: File exists
该冲突源于缓存了整个
~/go/pkg/mod目录,而 Go 1.24/工具链管理机制以及actions/setup-go本身已会在模块缓存下填充由工具链管理的文件。在已存在工具链文件的情况下恢复该缓存,导致 Go 1.24 矩阵任务失败。本次修复移除了针对 Go 模块的冗余手动
actions/cache步骤,改为由actions/setup-go@v5以go.sum作为依赖键来处理 Go 缓存。构建或测试命令本身未作更改:工作流仍然执行相同的前端构建、make fmt check和make test。变更后,两个 Go CI 矩阵任务均通过: