fix(triple): skip unsupported compat trailer attachments#3418
Open
leno23 wants to merge 3 commits into
Open
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #3418 +/- ##
===========================================
+ Coverage 46.76% 53.53% +6.76%
===========================================
Files 295 493 +198
Lines 17172 38379 +21207
===========================================
+ Hits 8031 20547 +12516
- Misses 8287 16179 +7892
- Partials 854 1653 +799 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Member
This was
linked to
issues
Jun 15, 2026
CAICAIIs
approved these changes
Jun 15, 2026
CAICAIIs
left a comment
Contributor
There was a problem hiding this comment.
Code path looks good to me.
and pr body can change Fixes part of #3093 to Refs #3093 and make sure it does not close the broader linked trackers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



What
Why
Issue #3093 reported that the old triple compat unary handler can panic when provider filters add internal attachments such as bool values. Those values should not fail the RPC response path just because they cannot be written as HTTP trailers.
Validation
Refs #3093