Skip to content

fix(triple): skip unsupported compat trailer attachments#3418

Open
leno23 wants to merge 3 commits into
apache:developfrom
leno23:codex/triple-compat-skip-unsupported-attachments-3093
Open

fix(triple): skip unsupported compat trailer attachments#3418
leno23 wants to merge 3 commits into
apache:developfrom
leno23:codex/triple-compat-skip-unsupported-attachments-3093

Conversation

@leno23

@leno23 leno23 commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

What

  • Skip old triple compat response attachments that cannot be represented as HTTP trailer values.
  • Keep string and []string attachments unchanged.
  • Add a regression test for bool attachment values.

Why

Issue #3093 reported that the old triple compat unary handler can panic when provider filters add internal attachments such as bool values. Those values should not fail the RPC response path just because they cannot be written as HTTP trailers.

Validation

  • go test ./protocol/triple/triple_protocol
  • go test ./protocol/triple/...
  • git diff --check

Refs #3093

@sonarqubecloud

Copy link
Copy Markdown

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 53.53%. Comparing base (60d1c2a) to head (a27918c).
⚠️ Report is 843 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3418      +/-   ##
===========================================
+ Coverage    46.76%   53.53%   +6.76%     
===========================================
  Files          295      493     +198     
  Lines        17172    38379   +21207     
===========================================
+ Hits          8031    20547   +12516     
- Misses        8287    16179    +7892     
- Partials       854     1653     +799     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Alanxtl

Alanxtl commented Jun 15, 2026

Copy link
Copy Markdown
Member

@NeverENG @CAICAIIs help review this

@CAICAIIs CAICAIIs left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code path looks good to me.
and pr body can change Fixes part of #3093 to Refs #3093 and make sure it does not close the broader linked trackers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3.3.2 version 3.3.2 ☢️ Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Enhancement] Complete delete config package [FEATURE] remove old triple protocol

4 participants