Skip to content

[CH] Support skewness aggregate function #12294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
navaneethsujith09 wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −4
Open

[CH] Support skewness aggregate function #12294

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion backends-clickhouse/src/main/scala/org/apache/gluten/utils/CHExpressionUtil.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,6 @@ object CHExpressionUtil {
URL_DECODE -> DefaultValidator(),
URL_ENCODE -> DefaultValidator(),
FORMAT_STRING -> FormatStringValidator(),
SKEWNESS -> DefaultValidator(),
MAKE_YM_INTERVAL -> DefaultValidator(),
MAP_ZIP_WITH -> DefaultValidator(),
KURTOSIS -> DefaultValidator(),
Expand Down
5 changes: 2 additions & 3 deletions ...house/src/test/scala/org/apache/gluten/execution/GlutenClickhouseCountDistinctSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,9 +103,8 @@ class GlutenClickhouseCountDistinctSuite extends GlutenClickHouseWholeStageTrans
// skewness agg is not supported, will cause fallback

@taiyang-li taiyang-li Jun 16, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls remove this comment

val sql = "select count(distinct(a,b)) , skewness(b) from " +
"values (0, null,1), (0,null,1), (1, 1,1), (2, 2, 1) ,(2,2,2),(3,3,3) as data(a,b,c)"
assertThrows[UnsupportedOperationException] {
spark.sql(sql).show
}
compareResultsAgainstVanillaSpark(sql, true, { _ => })

@taiyang-li taiyang-li Jun 16, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

besides, pls make sure skewness related uts in spark are enabled in gluten + CH


}

test("check count distinct with expr fallback") {
Expand Down
7 changes: 7 additions & 0 deletions cpp-ch/local-engine/Parser/aggregate_function_parser/SimpleStatisticsFunctions.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,14 @@ class AggregateFunctionParserStddev final : public AggregateFunctionParser
return func_node;
}
};
// for skewness
struct SkewnessNameStruct
{
static constexpr auto spark_name = "skewness";
static constexpr auto ch_name = "skewSamp";
};

static const AggregateFunctionParserRegister<AggregateFunctionParserStddev<SkewnessNameStruct>> registerer_skewness;
Comment on lines +66 to +73
static const AggregateFunctionParserRegister<AggregateFunctionParserStddev<StddevNameStruct>> registerer_stddev;
static const AggregateFunctionParserRegister<AggregateFunctionParserStddev<StddevSampNameStruct>> registerer_stddev_samp;
}
Loading