Hibernate 7 - Step 2

.agents/skills/codebase-memory/SKILL.md

@@ -0,0 +1,104 @@
+---
+name: codebase-memory-setup
+description: Helps the developer set up codebase-memory-mcp locally
+license: Apache-2.0
+---
+<!--
+SPDX-License-Identifier: Apache-2.0
+
+Licensed to the Apache Software Foundation (ASF) under one or more contributor license agreements; and to You under the Apache License, Version 2.0. 
+-->
+
+---
+name: codebase-memory-setup
+description: >
+Verify and set up the codebase-memory MCP server for Grails-Core architectural navigation.
+Use this skill at the start of any Grails-Core session to detect whether the MCP server is
+active, prompt the user to install it if missing, and provide step-by-step configuration
+instructions. Trigger whenever working with grails-core and MCP tool availability is unknown,
+or when the user asks about faster codebase navigation, architectural mode, or MCP setup.
+---
+
+# Codebase Memory MCP: Environment Verification & Setup
+
+This skill governs how to verify, onboard, and configure the `codebase-memory` MCP server when
+working in the Grails-Core repository. It enables "Architectural Mode" — a significantly faster
+mode of codebase navigation using graph-based memory tools.
+
+---
+
+## Step 1: Detect Operating Mode (Mandatory on Load)
+
+Before doing anything else, check your available tool definitions for the presence of any of
+these tools:
+
+- `index_repository`
+- `search_graph`
+- `trace_call_path`
+- `query_graph`
+
+| Condition | Mode |
+|---|---|
+| Tools **present** | **Architectural Mode** — proceed normally |
+| Tools **absent** | **Standard Mode** — proceed to Step 2 |
+
+---
+
+## Step 2: Proactive Onboarding (Standard Mode Only)
+
+If the MCP server is **not** detected, interrupt the current flow (unless addressing a critical
+fix) and present the following message to the user:
+
+> "I've detected that this repository is optimized for **Codebase Memory MCP**, which allows me
+> to navigate the Grails-Core architecture 90% faster. However, the server is not currently
+> running in your environment. Would you like me to help you install it now?"
+
+Wait for the user's response before continuing.
+
+---
+
+## Step 3: Installation (If User Approves)
+
+The package ships as a **static binary** (not npm). Use the appropriate one-liner for the user's
+platform, or run it yourself if you have shell access.
+
+**macOS / Linux (bash):**
+
+```bash
+curl -fsSL https://raw.githubusercontent.com/DeusData/codebase-memory-mcp/main/install.sh | bash
+```
+
+**Windows (PowerShell):**
+
+```powershell
+irm https://raw.githubusercontent.com/DeusData/codebase-memory-mcp/main/scripts/setup-windows.ps1 | iex
+```
+
+Both scripts download the correct binary for the platform, place it on the PATH, and run
+`codebase-memory-mcp install` to auto-configure all detected agents (Claude Code, Zed, Cursor,
+etc.) in one step.
+
+> **Note:** `npm install -g codebase-memory-mcp` will not work — ignore any documentation
+> suggesting this.
+
+After the script completes, restart the agent environment.
+
+### Index the Repository
+
+Once the server is active, index grails-core by telling the agent:
+
+```
+"Index this project"
+```
+
+The agent will call `index_repository` and build the knowledge graph automatically.
+
+---
+
+## Step 4: Verify Activation
+
+Confirm that `index_repository`, `search_graph`, `trace_call_path`, and `query_graph` are now
+available. If they are, **Architectural Mode** is active — proceed with the original task.
+
+If tools are still missing, ask the user to confirm the install script completed without errors
+and that the agent environment was fully restarted.

.agents/skills/grails-developer/SKILL.md

@@ -1,28 +1,13 @@
-<!--
-SPDX-License-Identifier: Apache-2.0
-
-Licensed under the Apache License, Version 2.0 (the "License");
-you may not use this file except in compliance with the License.
-You may obtain a copy of the License at
-
-    https://www.apache.org/licenses/LICENSE-2.0
-
-Unless required by applicable law or agreed to in writing, software
-distributed under the License is distributed on an "AS IS" BASIS,
-WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-See the License for the specific language governing permissions and
-limitations under the License.
--->
 ---
 name: grails-developer
 description: Comprehensive guide for Grails 7 development, covering web applications, REST APIs, GORM, controllers, services, views, plugins, and testing with Spock and Geb
 license: Apache-2.0
-compatibility: opencode, claude, grok, gemini, copilot, cursor, windsurf
-metadata:
-  audience: developers
-  frameworks: grails
-  versions: 7
 ---
+<!--
+SPDX-License-Identifier: Apache-2.0
+
+Licensed to the Apache Software Foundation (ASF) under one or more contributor license agreements; and to You under the Apache License, Version 2.0. 
+-->
 
 ## What I Do
 

.agents/skills/groovy-developer/SKILL.md

@@ -1,29 +1,13 @@
-<!--
-SPDX-License-Identifier: Apache-2.0
-
-Licensed under the Apache License, Version 2.0 (the "License");
-you may not use this file except in compliance with the License.
-You may obtain a copy of the License at
-
-    https://www.apache.org/licenses/LICENSE-2.0
-
-Unless required by applicable law or agreed to in writing, software
-distributed under the License is distributed on an "AS IS" BASIS,
-WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-See the License for the specific language governing permissions and
-limitations under the License.
--->
 ---
 name: groovy-developer
 description: Expert guide for Groovy 4 development, covering concise syntax, closures, DSLs, metaprogramming, static compilation, and integration with Java 17 and Grails
 license: Apache-2.0
-compatibility: opencode, claude, grok, gemini, copilot, cursor, windsurf
-metadata:
-  audience: developers
-  languages: groovy, java
-  versions: 4.0
-  paradigms: dynamic, static, functional, object-oriented, DSL-oriented
 ---
+<!--
+SPDX-License-Identifier: Apache-2.0
+
+Licensed to the Apache Software Foundation (ASF) under one or more contributor license agreements; and to You under the Apache License, Version 2.0. 
+-->
 
 ## What I Do
 

.agents/skills/hibernate-developer/SKILL.md

@@ -0,0 +1,119 @@
+---
+name: hibernate-developer
+description: Guide for working in the grails-data-hibernate7 module, especially Hibernate 7 domain binding, mapping migration, generators, and integration tests. Use this when changing code or tests under grails-data-hibernate7.
+license: Apache-2.0
+---
+<!--
+SPDX-License-Identifier: Apache-2.0
+
+Licensed to the Apache Software Foundation (ASF) under one or more contributor license agreements; and to You under the Apache License, Version 2.0. 
+-->
+
+## What I Do
+
+- Provide repository-specific guidance for the `grails-data-hibernate7` project.
+- Help with Hibernate 7 migration work in domain binding, mapping metadata, identifiers, generators, collections, and second-pass binding.
+- Guide changes around `GrailsDomainBinder`, `GrailsPropertyBinder`, `IdentityBinder`, `VersionBinder`, collection binders, and related utilities.
+- Keep changes aligned with the testing constraints and migration status documented in `grails-data-hibernate7/AGENTS.md`.
+
+## When to Use Me
+
+Activate this skill when working on the Hibernate 7 module, especially for:
+
+- Changes under `grails-data-hibernate7/**`.
+- Hibernate 7 mapping and metadata binding work.
+- Identifier, version, collection, association, or generator binding changes.
+- Hibernate 7 regression fixes and migration follow-up tasks.
+- Specs that exercise Hibernate-backed mapping behavior rather than lightweight unit behavior.
+
+## Module Context
+
+This skill is for the Grails framework's Hibernate 7 integration module, not for a Grails application. Prefer guidance from this skill over generic Grails app patterns when working in `grails-data-hibernate7`.
+
+`GrailsDomainBinder` is the main entry point for binding Grails domain classes to Hibernate metadata. Changes often ripple through:
+
+- `org.grails.orm.hibernate.cfg`
+- `org.grails.orm.hibernate.cfg.domainbinding`
+- `org.grails.orm.hibernate.cfg.domainbinding.collectionType`
+- `org.grails.orm.hibernate.cfg.domainbinding.secondpass`
+- `org.grails.orm.hibernate.cfg.domainbinding.generator`
+
+## Key Classes and Responsibilities
+
+### Main Binding Flow
+
+- `GrailsDomainBinder`: central coordinator for Hibernate 7 mapping contribution.
+- `GrailsPropertyBinder`: main coordinator for converting persistent properties into Hibernate `Value` instances.
+- `PropertyFromValueCreator`: shared utility for creating Hibernate `Property` instances from a bound `Value`.
+
+### Identifier and Version Binding
+
+- `IdentityBinder`: coordinates identifier binding.
+- `SimpleIdBinder`: handles simple identifiers.
+- `CompositeIdBinder`: handles composite identifiers.
+- `VersionBinder`: binds optimistic locking version properties.
+- `NaturalIdentifierBinder`: binds `naturalId` properties.
+
+### Associations and Collections
+
+- `OneToOneBinder`, `ManyToOneBinder`, `ManyToOneValuesBinder`: association binding.
+- `CollectionBinder`: collection mapping.
+- `CollectionSecondPassBinder`, `ListSecondPassBinder`, `MapSecondPassBinder`: second-pass association and collection binding.
+- `CollectionHolder` plus the collection type classes: carry collection metadata through binding.
+
+### Value and Column Binding
+
+- `SimpleValueBinder`: binds simple properties.
+- `SimpleValueColumnBinder`: binds columns to simple values.
+- `ComponentBinder`, `ComponentPropertyBinder`: embedded/component binding.
+- `EnumTypeBinder`: enum mapping.
+
+### Generators
+
+- `BasicValueCreator`: creates identifier values and generators.
+- `GrailsSequenceWrapper`, `GrailsSequenceGeneratorEnum`: generator integration helpers.
+- `GrailsIdentityGenerator`, `GrailsIncrementGenerator`, `GrailsNativeGenerator`, `GrailsSequenceStyleGenerator`, `GrailsTableGenerator`: Grails-specific Hibernate 7 generator implementations.
+
+## Current Module Guidance
+
+Keep these module-specific expectations in mind:
+
+- `GrailsPropertyBinder` has already been simplified to a unified binder-dispatch structure. Preserve that consolidation instead of reintroducing scattered property creation or ad hoc branching.
+- Property creation and addition should stay centralized through callers using `PropertyFromValueCreator` where applicable.
+- Utility classes in `domainbinding.util` should prefer Hibernate-aware GORM types internally, but public signatures may still need base interfaces when Spock mocks require them.
+- `GrailsIncrementGenerator` still contains reflection-based Hibernate 7 compatibility workarounds; avoid broad refactors unless the change explicitly addresses that area.
+
+## Testing Rules
+
+When touching `grails-data-hibernate7`, test through real Hibernate wiring rather than assuming mocks are enough.
+
+- Use `HibernateGormDatastoreSpec` for Hibernate 7 integration and domain-binding specifications.
+- Prefer `manager.addAllDomainClasses([...])` in `setupSpec()` to register entities for specs.
+- Define test entities as top-level classes in the same Groovy spec file.
+- Ensure test domain class names are globally unique within the package to avoid collisions during parallel execution.
+- Prefer real entities over heavy mocking for binder logic.
+
+## Change Workflow
+
+1. Identify which binder, creator, generator, fetcher, or second-pass class owns the behavior.
+2. Trace whether the change affects only `Value` creation, `Property` creation, or both.
+3. Preserve the existing separation between logical mapping decisions and Hibernate object construction.
+4. Update or add specs in `grails-data-hibernate7` that exercise the affected behavior through the public Hibernate-backed path.
+5. Run the relevant Hibernate 7 module tests, and expand test coverage when binder flow or entity registration behavior changes.
+
+## Pitfalls to Avoid
+
+- Do not treat this module like a simple Grails application layer; it is framework and mapping infrastructure code.
+- Do not reintroduce duplicated property-creation logic if a shared binder or creator already owns it.
+- Do not rely on unit-only mocking for Hibernate internals when the behavior depends on real metadata binding.
+- Do not use nested or inner entity classes in Hibernate 7 specs when top-level classes are required for AST transforms and reliable registration.
+
+## Known Status and Constraints
+
+- The Hibernate 7 binder migration is largely in migrated state across the main binders, collection types, second-pass binders, generators, and utilities.
+- Unidirectional many-to-many support in `CollectionSecondPassBinder` is implemented.
+- `GrailsIncrementGenerator` reflection hacks remain a known temporary compromise until a later Hibernate upgrade removes the need.
+
+## Source of Truth
+
+This skill is derived from `grails-data-hibernate7/AGENTS.md`. When the module guidance changes, update this skill so agents can load the same rules directly from `.agents/skills/hibernate-developer/SKILL.md`.

.agents/skills/java-developer/SKILL.md

@@ -1,28 +1,13 @@
-<!--
-SPDX-License-Identifier: Apache-2.0
-
-Licensed under the Apache License, Version 2.0 (the "License");
-you may not use this file except in compliance with the License.
-You may obtain a copy of the License at
-
-    https://www.apache.org/licenses/LICENSE-2.0
-
-Unless required by applicable law or agreed to in writing, software
-distributed under the License is distributed on an "AS IS" BASIS,
-WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-See the License for the specific language governing permissions and
-limitations under the License.
--->
 ---
 name: java-developer
 description: Guide for developing in Java 17 LTS, including modern features, best practices, and integration with Groovy/Grails projects
 license: Apache-2.0
-compatibility: opencode, claude, grok, gemini, copilot, cursor, windsurf
-metadata:
-  audience: developers
-  languages: java
-  versions: 17
 ---
+<!--
+SPDX-License-Identifier: Apache-2.0
+
+Licensed to the Apache Software Foundation (ASF) under one or more contributor license agreements; and to You under the Apache License, Version 2.0. 
+-->
 
 ## What I Do