HIVE-29035 : new version of cache #6441
Open
henrib wants to merge 11 commits intoapache:masterfrom
Open
Conversation
…e DB to ensure no stale table object is returned;
- improved check; - quiesce console logs due to internal throws in servlet;
asf-ci-hive
added
tests pending
tests unstable
and removed
tests unstable
tests pending
labels
asf-ci-hive
added
tests pending
tests passed
and removed
tests unstable
tests pending
labels
Contributor
Author
|
@ayushtkn if you have some spare time to review, thanks |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 9 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
asf-ci-hive
added
tests passed
tests pending
and removed
tests pending
tests passed
labels
asf-ci-hive
added
tests pending
tests passed
and removed
tests failed
tests pending
labels
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 7 out of 7 changed files in this pull request and generated 12 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+109
to
+112
| HttpResponse<String> response; | ||
| try (HttpClient client = HttpClient.newHttpClient()) { | ||
| response = client.send(request, HttpResponse.BodyHandlers.ofString()); | ||
| } |
asf-ci-hive
added
tests passed
tests pending
and removed
tests pending
tests passed
labels
Contributor
|
@henrib Could you please rebase this branch? My update introduced a conflict. Thanks. |
asf-ci-hive
added
tests failed
tests pending
and removed
tests pending
tests failed
labels
|
Member
|
@henrib there are some warnings from Sonar & I feel few could be fixed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This checks the table location from HMS DB to ensure no stale table object is returned;