Repository navigation
KAFKA-21307: Add share group DLQ setup to ShareConsumeBenchSpec - #23867
Merged
Merged
Conversation
…reConsumeBenchSpec Add two optional fields to ShareConsumeBenchSpec: - shareGroupDLQConfig: the DLQ topic name, its PartitionsSpec and copyRecordEnable. Before the consumers start, ShareConsumeBenchWorker creates the DLQ topic, enables it for use as a DLQ, and sets the DLQ topic name and copy record configs on the share group. - recordAcknowledger: a RecordAcknowledger, following the RecordProcessor pattern, that returns the AcknowledgeType for each consumed record. RandomRecordAcknowledger is the first implementation. Its counts are reported in the worker status. recordAcknowledger makes the consumers use explicit acknowledgement mode and cannot be combined with acknowledgeType. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…pDLQConfig Follow the existing spec convention: only pluggable components such as recordProcessor and recordAcknowledger take Optional constructor parameters. Simple values keep a nullable parameter that is wrapped in an Optional, which the getter returns. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
AndrewJSchofield
approved these changes
Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add two optional fields to ShareConsumeBenchSpec:
copyRecordEnable. Before the consumers start, ShareConsumeBenchWorker
creates the DLQ topic, enables it for use as a DLQ, and sets the DLQ
topic name and copy record configs on the share group.
RecordProcessor pattern, that returns the AcknowledgeType for each
consumed record. RandomRecordAcknowledger is the first implementation.
Its counts are reported in the worker status.
recordAcknowledger makes the consumers use explicit acknowledgement mode
and cannot be combined with acknowledgeType.
Reviewers: Andrew Schofield aschofield@confluent.io