Repository navigation
KAFKA-21266: Compute the effective min ISR from the target partition - #23895
Draft
unknowntpo wants to merge 1 commit into
Draft
unknowntpo wants to merge 1 commit into
unknowntpo wants to merge 1 commit into
Conversation
The controller used the replica count of partition 0 to compute the effective min ISR for every partition of the topic. Partitions of one topic can have different replication factors, so a small partition 0 could lower the min ISR of other partitions and clear their ELR too early. Use the replicas of the partition being changed instead. All callers already have that partition. The test helper newAlterPartition always used partition index 0. It now uses the given partition. Generated-by: Claude Opus 5.5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The controller used the replica count of partition 0 to compute the
effective min ISR for every partition of a topic. Partitions can have
different replication factors, so a small partition 0 could lower the
min ISR of other partitions and clear their ELR too early.
This patch uses the replicas of the partition being changed. All callers
already have that partition.
The test helper
newAlterPartitionalways used partition index 0. Itnow uses the given partition.