KNOX-3328: Add Docker-based integration tests for Knox LDAP service#1242
Merged
Conversation
Contributor
Author
|
Cc. @handavid |
hanicz
requested changes
May 28, 2026
Test Results21 tests 21 ✅ 1s ⏱️ Results for commit 75a2c68. |
hanicz
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
KNOX-3328 - Add Docker-based integration tests for Knox LDAP service
What changes were proposed in this pull request?
This PR enhances the integrated Knox LDAP service to support authentication (bind operations) and dynamic user/group lookups by proxying requests to an external LDAP backend.
These changes enable the Knox LDAP service to act as a functional LDAP interface for applications that require LDAP-based authentication while delegating the actual identity management to a primary directory service.
Key enhancements include:
GroupLookupInterceptorthat allows the Knox LDAP server to authenticate users against a configured backend (e.g., an external LDAP server or a local file-based store).KnoxLDAPServerManagerto insert theGroupLookupInterceptorbefore the standard AuthenticationInterceptor. This allows Knox to intercept and process bind requests for non-system users.LdapProxyBackend,FileBackend) with an authenticate method to support password verification.mina-corefromtestscope to compile scope ingateway-serverto support the LDAP server's runtime requirements.test_knox_auth_service_and_LDAP.pyto match the updated service endpoints and configurations.How was this patch tested?
I built Knox locally then ran Docker-based integration tests:
Integration Tests
The updated LDAP-related integration tests are now connection to the embedded Knox LDAP service instead of the demo LDAP running in a different container.
UI changes
N/A