Skip to content

Optimize GroupFacetCollector.getFacetEntries() #15947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dweiss merged 4 commits into from
Apr 27, 2026
+6 −1
Merged

Optimize GroupFacetCollector.getFacetEntries() #15947

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
acd592d
Optimize GroupFacetCollector.getFacetEntries()
gaobinlong Apr 10, 2026
367f3cd
Merge remote-tracking branch 'upstream/main' into groupFacetCollector
gaobinlong Apr 12, 2026
dbacda5
Revert some change
gaobinlong Apr 12, 2026
b3cb31f
Merge branch 'main' into groupFacetCollector
dweiss Apr 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion lucene/grouping/src/java/org/apache/lucene/search/grouping/GroupFacetCollector.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@

import java.io.IOException;
import java.util.ArrayList;
import java.util.Collections;
import java.util.Comparator;
import java.util.List;
import java.util.NavigableSet;
Expand Down Expand Up @@ -181,7 +182,11 @@ public void addFacetCount(BytesRef facetValue, int count) {
* @return a list of facet entries to be rendered based on the specified offset and limit
*/
public List<FacetEntry> getFacetEntries(int offset, int limit) {
List<FacetEntry> entries = new ArrayList<>();
if (offset >= facetEntries.size()) {
return Collections.emptyList();
}

List<FacetEntry> entries = new ArrayList<>(Math.min(limit, facetEntries.size() - offset));

int skipped = 0;
int included = 0;
Expand Down
Loading