Open
Conversation
Contributor
Author
|
I get some number on building index of 1M uuids. FINAL STATS (1 Million 16-byte UUIDs)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR speeds up
TrieBuilderand reduces its memory footprint by replacing the in-memory object tree with a compact prefix-coded byte buffer during the building phase, and using a frontier-based approach during the saving phase.Previously,
TrieBuilderconstructed a large in-memory tree usingNodeobjects. This approach was memory-intensive (O(total nodes * ~120 bytes per node)) and caused massive object allocations, which made it incredibly slow when dealing with large terms.Main Changes
NodeandSaveFrameclasses with a sequentialByteBuffersDataOutputbuffer. Entries are now prefix-encoded (storing prefix length, suffix length, and suffix bytes) and appended sequentially.minKey) is stored separately. This allows theappend()method to re-encode only the first entry and bulk-copy the remaining bytes with zero per-entry overhead.saveNodes()using aFrontierNodearray bounded bymaxKeyDepth, rather than requiring the whole tree to exist in memory.statusmanagement because nothing got destroyed afterappendorsave.Memory & Performance Impact