Skip to content

feat(services/s3): add R2 and MinIO presets - #8013

Draft
Xuanwo wants to merge 4 commits into
mainfrom
xuanwo/s3-provider-presets
Draft

Xuanwo wants to merge 4 commits into
mainfrom
xuanwo/s3-provider-presets

Conversation

@Xuanwo

@Xuanwo Xuanwo commented Aug 2, 2026 •

Copy link
Copy Markdown
Member

Which issue does this PR close?

Part of #8003.

Rationale for this change

Cloudflare R2 and MinIO expose S3-compatible APIs, but each provider has a smaller configuration contract and distinct endpoint, region, and credential rules. Requiring users to configure them through the generic s3 service adds avoidable setup and exposes options that do not belong to those providers.

Dedicated presets provide provider-owned defaults and validation while continuing to share the S3 runtime. The generic s3 service remains the escape hatch for the complete S3 configuration surface.

What changes are included in this PR?

  • Add R2/R2Config and Minio/MinioConfig with dedicated r2:// and minio:// schemes.
  • Add independent services-r2 and services-minio facade features. Enabling services-s3 does not enable either preset.
  • Register the new schemes for URI and iterator construction while preserving direct builder construction.
  • Update generated Python, Java, and .NET configs, Python scheme stubs, service documentation, RFC 7948, and behavior-test planning and fixtures.
  • Keep generic S3 testing on Silo and run the MinIO presets against the pinned official MinIO release binary, with its SHA-256 verified at image build time.
  • Keep compatible_services.md as the guide for providers that still use the generic s3 service.

Are there any user-facing changes?

Yes. Rust users can enable only the provider they need and configure its smaller contract. R2 can derive its endpoint from account_id; MinIO requires its deployment endpoint and defaults the signing region to auto. Existing s3 configurations remain unchanged.

How was this change tested?

Validation on the branch integrating main ac07ab094 (head 7bd65abc4):

  • Real MinIO RELEASE.2024-09-22T00-33-43Z behavior tests: authenticated and anonymous modes each passed 129 tests. Tests ran against the official Linux binary locally; the Docker Compose fixture still needs CI execution.
  • S3 unit tests and doctests: 86 passed, 7 ignored. Independent facade registration tests passed for no service feature, S3 only, R2 only, and MinIO only.
  • Core workspace all-features/all-targets Clippy and Python binding Clippy passed.
  • Generator tests: 32 passed. Python, Java, website, and .NET generation was reproducible. Behavior planner tests: 14 passed.
  • Regenerated Python stubs; Python lint and type checks passed. Construction tests with the memory fixture: 21 passed, 6 skipped. A separate Python probe checked typed preset construction, rejected AWS-only fields, and completed MinIO write/read/delete.
  • Repository Rust formatting and diff checks passed.

R2 cloud behavior has not been validated locally. The previous R2 CI failure logs expired, so its cause remains unknown pending a fresh run. .NET generated configs have not been compiled locally. Earlier implementation evidence included 118 passing MinIO tests in each authentication mode; those counts describe the old revision, not the current suite.

Breaking changes

None.

AI Usage Statement

  • Harness: OpenAI Codex. Model: GPT-5. Effort: not recorded in the historical handoff. Role: initial implementation and validation.
  • Harness: T3 Code through the Codex harness. Model: gpt-6-astra. Effort: high. Role: main integration, fixture and generated binding repairs, and local validation. R2 cloud behavior, the Docker fixture, and .NET compilation remain subject to CI validation.

@github-actions github-actions Bot added releases-note/feat The PR implements a new feature or has a title that begins with "feat" services/s3 size:XXL This PR changes 1000+ lines, ignoring generated files. labels Nov 12, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

releases-note/feat The PR implements a new feature or has a title that begins with "feat" services/s3 size:XXL This PR changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant