Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #8036.
Rationale for this change
Fixed concurrency and bandwidth limits do not adapt to backend request-rate throttling. Add an optional AIMD layer that paces HTTP requests and adjusts its rate from OpenDAL's typed
RateLimitedfeedback.What changes are included in this PR?
opendal-layer-aimdwith independent read, write, delete, and list token buckets. Active windows increase rates additively; windows observingRateLimiteddecrease them multiplicatively within configured bounds. Empty windows leave rates unchanged.Operationmarker, including pagination and multipart requests. Observe parsed errors through service and I/O wrappers. Unmarked requests, presigning, and non-HTTP I/O bypass pacing.with_sleep.Admission counts HTTP requests, while feedback belongs to the enclosing storage operation; composite operations may use multiple request categories. The controller therefore uses the presence of
RateLimited, rather than a ratio of errors to requests. Pacing occurs after signing, and transport-internal redirects or retries are outside the admission boundary.Are there any user-facing changes?
Enable
layers-aimdto useopendal::layers::{AimdConfig, AimdLayer}, or depend on the standalone layer crate. Add AIMD before a retry layer so it observes each attempt's errors. The layer does not retry or change error semantics. Existing users are unaffected unless they opt in.Breaking changes
AI Usage Statement
gpt-6-astra.high.