Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #8506.
Rationale for this change
azblob doesn't declare
list_with_start_after, but itslistsilently dropped the option, so every lister started from the beginning. Reproduced against a real storage account:lister_with("").start_after("a")overa,b,creturned all three.A check in
CorrectnessCheckLayerwould cover every service, but cos honorsstart_afteronly for versioned listing without declaring it, so a generic check would reject that working path. This PR fixes azblob and leaves the generic check as a follow-up.What changes are included in this PR?
listreturnsUnsupportedwhenstart_afteris set.Verified against a real storage account: the call now fails with
Unsupported, and the azblob behavior suite passes (144/144).Are there any user-facing changes?
Listing azblob with
start_afternow returnsUnsupportedinstead of ignoring it.Breaking changes
AI Usage Statement
AI-assisted implementation.