HDDS-15682. Use the original configured host and port to identify SCM nodes #10612
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,92 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one or more | ||
| * contributor license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright ownership. | ||
| * The ASF licenses this file to You under the Apache License, Version 2.0 | ||
| * (the "License"); you may not use this file except in compliance with | ||
| * the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.apache.hadoop.hdds.scm.net; | ||
|
|
||
| import java.net.InetSocketAddress; | ||
| import org.apache.hadoop.net.NetUtils; | ||
|
|
||
| /** | ||
| * A class for host and port. | ||
| * It also has an address which can be updated from time to time. | ||
| */ | ||
| public class HostAndPort { | ||
|
Contributor
There was a problem hiding this comment. Minor (naming): this collides with Guava's — Claude Code (AI-assisted review)
Contributor
There was a problem hiding this comment. We can replace Guava's |
||
| private final String host; | ||
| private final int port; | ||
| private final String hostAndPortString; | ||
| private final int hash; | ||
| /** The address can be updated from time to time. */ | ||
| private InetSocketAddress address; | ||
|
|
||
| private HostAndPort(String host, int port, InetSocketAddress address) { | ||
| this.host = host; | ||
| this.port = port; | ||
| this.hostAndPortString = host + ":" + port; | ||
| this.hash = host.hashCode() ^ Integer.hashCode(port); | ||
| this.address = address != null ? address : NetUtils.createSocketAddr(hostAndPortString); | ||
|
Contributor
There was a problem hiding this comment. The constructor resolves eagerly. For the block/client/security addresses in — Claude Code (AI-assisted review)
Contributor
There was a problem hiding this comment. Use
Contributor
Author
There was a problem hiding this comment.
Let's change the address resolution logic in HDDS-15533. This PR just do refactoring. |
||
| } | ||
|
|
||
| public HostAndPort(String host, int port) { | ||
| this(host, port, null); | ||
| } | ||
|
|
||
| public HostAndPort(InetSocketAddress address) { | ||
|
Contributor
There was a problem hiding this comment.
— Claude Code (AI-assisted review)
Contributor
Author
There was a problem hiding this comment. This is only used in ContainerTestUtils. Let me change the code there. |
||
| this(address.getHostName(), address.getPort(), address); | ||
| } | ||
|
|
||
| public String getHostName() { | ||
| return host; | ||
| } | ||
|
|
||
| public int getPort() { | ||
| return port; | ||
| } | ||
|
|
||
| public String getHostAndPortString() { | ||
| return hostAndPortString; | ||
| } | ||
|
|
||
| public synchronized InetSocketAddress getAddress() { | ||
|
Contributor
There was a problem hiding this comment. why is this synchronized?
Contributor
Author
There was a problem hiding this comment. It is for HDDS-15533, which will update it. Actually, let's remove it here and add it there. |
||
| return address; | ||
| } | ||
|
|
||
| @Override | ||
| public int hashCode() { | ||
| return hash; | ||
| } | ||
|
|
||
| @Override | ||
| public boolean equals(Object obj) { | ||
| if (this == obj) { | ||
| return true; | ||
| } else if (!(obj instanceof HostAndPort)) { | ||
| return false; | ||
| } | ||
| final HostAndPort that = (HostAndPort) obj; | ||
| // address must not be compared | ||
| return this.hash == that.hash | ||
| && this.port == that.port | ||
| && this.host.equals(that.host); | ||
| } | ||
|
|
||
| @Override | ||
| public String toString() { | ||
| final InetSocketAddress a = getAddress(); | ||
| final Object resolved = a != null && a.getAddress() != null ? a.getAddress() : "<unresolved>"; | ||
| return hostAndPortString + "/" + resolved; | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -39,7 +39,6 @@ | |
| import com.google.common.collect.Sets; | ||
| import java.io.File; | ||
| import java.io.IOException; | ||
| import java.util.Arrays; | ||
| import java.util.Collection; | ||
| import java.util.HashMap; | ||
|
|
@@ -71,6 +70,7 @@ | |
| import org.apache.hadoop.hdds.protocol.DiskBalancerProtocol; | ||
| import org.apache.hadoop.hdds.protocol.SecretKeyProtocol; | ||
| import org.apache.hadoop.hdds.protocolPB.SCMSecurityProtocolClientSideTranslatorPB; | ||
| import org.apache.hadoop.hdds.scm.net.HostAndPort; | ||
| import org.apache.hadoop.hdds.security.SecurityConfig; | ||
| import org.apache.hadoop.hdds.security.symmetric.DefaultSecretKeyClient; | ||
| import org.apache.hadoop.hdds.security.symmetric.SecretKeyClient; | ||
|
|
@@ -764,12 +764,12 @@ private String reconfigScmNodes(String value) { | |
| LOG.info("Reconfiguring SCM nodes for service ID {} with new SCM nodes {} and remove SCM nodes {}", | ||
| scmServiceId, scmNodesIdsToAdd, scmNodesIdsToRemove); | ||
|
|
||
| final Collection<Pair<String, HostAndPort>> scmToAdd = HddsServerUtil.getSCMAddressForDatanodes( | ||
| getConf(), scmServiceId, scmNodesIdsToAdd); | ||
| if (scmToAdd == null) { | ||
| throw new IllegalStateException("Reconfiguration failed to get SCM address to add due to wrong configuration"); | ||
| } | ||
| final Collection<Pair<String, HostAndPort>> scmToRemove = HddsServerUtil.getSCMAddressForDatanodes( | ||
| getConf(), scmServiceId, scmNodesIdsToRemove); | ||
| if (scmToRemove == null) { | ||
| throw new IllegalArgumentException( | ||
|
|
@@ -790,10 +790,10 @@ private String reconfigScmNodes(String value) { | |
| } | ||
|
|
||
| // Add the new SCM servers | ||
| for (Pair<String, HostAndPort> pair : scmToAdd) { | ||
| String scmNodeId = pair.getLeft(); | ||
| final HostAndPort scmAddress = pair.getRight(); | ||
| if (scmAddress.getAddress().isUnresolved()) { | ||
| LOG.warn("Reconfiguration failed to add SCM address {} for SCM service {} since it can't " + | ||
| "be resolved, skipping", scmAddress, scmServiceId); | ||
| continue; | ||
|
|
@@ -809,9 +809,9 @@ private String reconfigScmNodes(String value) { | |
| } | ||
|
|
||
| // Remove the old SCM server | ||
| for (Pair<String, HostAndPort> pair : scmToRemove) { | ||
| String scmNodeId = pair.getLeft(); | ||
| final HostAndPort scmAddress = pair.getRight(); | ||
| try { | ||
| connectionManager.removeSCMServer(scmAddress); | ||
| context.removeEndpoint(scmAddress); | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -21,11 +21,11 @@ | |
|
|
||
| import com.google.common.annotations.VisibleForTesting; | ||
| import com.google.common.base.CaseFormat; | ||
| import java.util.HashMap; | ||
| import java.util.Map; | ||
| import org.apache.commons.text.WordUtils; | ||
| import org.apache.hadoop.hdds.protocol.proto.StorageContainerDatanodeProtocolProtos.SCMCommandProto; | ||
| import org.apache.hadoop.hdds.scm.net.HostAndPort; | ||
| import org.apache.hadoop.hdfs.util.EnumCounters; | ||
| import org.apache.hadoop.metrics2.MetricsCollector; | ||
| import org.apache.hadoop.metrics2.MetricsInfo; | ||
|
|
@@ -68,9 +68,9 @@ public final class DatanodeQueueMetrics implements MetricsSource { | |
|
|
||
| private Map<SCMCommandProto.Type, MetricsInfo> stateContextCommandQueueMap; | ||
| private Map<SCMCommandProto.Type, MetricsInfo> commandDispatcherQueueMap; | ||
| private Map<HostAndPort, MetricsInfo> incrementalReportsQueueMap; | ||
| private Map<HostAndPort, MetricsInfo> containerActionQueueMap; | ||
| private Map<HostAndPort, MetricsInfo> pipelineActionQueueMap; | ||
|
|
||
| public DatanodeQueueMetrics(DatanodeStateMachine datanodeStateMachine) { | ||
| this.registry = new MetricsRegistry(METRICS_SOURCE_NAME); | ||
|
|
@@ -132,19 +132,19 @@ public void getMetrics(MetricsCollector collector, boolean b) { | |
| tmpEnum.get(entry.getKey())); | ||
| } | ||
|
|
||
| for (Map.Entry<HostAndPort, MetricsInfo> entry: | ||
| incrementalReportsQueueMap.entrySet()) { | ||
| builder.addGauge(entry.getValue(), | ||
| datanodeStateMachine.getContext() | ||
| .getIncrementalReportQueueSize().getOrDefault(entry.getKey(), 0)); | ||
| } | ||
| for (Map.Entry<HostAndPort, MetricsInfo> entry: | ||
| containerActionQueueMap.entrySet()) { | ||
| builder.addGauge(entry.getValue(), | ||
| datanodeStateMachine.getContext() | ||
| .getContainerActionQueueSize().getOrDefault(entry.getKey(), 0)); | ||
| } | ||
| for (Map.Entry<HostAndPort, MetricsInfo> entry: | ||
| pipelineActionQueueMap.entrySet()) { | ||
| builder.addGauge(entry.getValue(), | ||
| datanodeStateMachine.getContext().getPipelineActionQueueSize() | ||
|
|
@@ -157,7 +157,7 @@ public static synchronized void unRegister() { | |
| DefaultMetricsSystem.instance().unregisterSource(METRICS_SOURCE_NAME); | ||
| } | ||
|
|
||
| public void addEndpoint(HostAndPort endpoint) { | ||
| incrementalReportsQueueMap.computeIfAbsent(endpoint, | ||
| k -> getMetricsInfo(INCREMENTAL_REPORT_QUEUE_PREFIX, | ||
| CaseFormat.UPPER_UNDERSCORE | ||
|
|
@@ -172,7 +172,7 @@ public void addEndpoint(InetSocketAddress endpoint) { | |
| .to(CaseFormat.UPPER_CAMEL, k.getHostName()))); | ||
| } | ||
|
|
||
| public void removeEndpoint(HostAndPort endpoint) { | ||
| incrementalReportsQueueMap.remove(endpoint); | ||
| containerActionQueueMap.remove(endpoint); | ||
| pipelineActionQueueMap.remove(endpoint); | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -22,7 +22,6 @@ | |
|
|
||
| import com.google.common.util.concurrent.ThreadFactoryBuilder; | ||
| import java.io.Closeable; | ||
| import java.time.ZonedDateTime; | ||
| import java.util.concurrent.ExecutorService; | ||
| import java.util.concurrent.Executors; | ||
|
|
@@ -31,6 +30,7 @@ | |
| import java.util.concurrent.locks.Lock; | ||
| import java.util.concurrent.locks.ReentrantLock; | ||
| import org.apache.hadoop.hdds.conf.ConfigurationSource; | ||
| import org.apache.hadoop.hdds.scm.net.HostAndPort; | ||
| import org.apache.hadoop.ozone.protocol.VersionResponse; | ||
| import org.apache.hadoop.ozone.protocolPB.ReconDatanodeProtocolPB; | ||
| import org.apache.hadoop.ozone.protocolPB.StorageContainerDatanodeProtocolClientSideTranslatorPB; | ||
|
|
@@ -46,7 +46,7 @@ public class EndpointStateMachine | |
| LOG = LoggerFactory.getLogger(EndpointStateMachine.class); | ||
| private final StorageContainerDatanodeProtocolClientSideTranslatorPB endPoint; | ||
| private final AtomicLong missedCount; | ||
| private final HostAndPort hostAndPort; | ||
| private final Lock lock; | ||
| private final ConfigurationSource conf; | ||
| private EndPointStates state = EndPointStates.FIRST; | ||
|
|
@@ -64,18 +64,17 @@ public class EndpointStateMachine | |
| * | ||
| * @param endPoint - RPC endPoint. | ||
| */ | ||
| public EndpointStateMachine(HostAndPort hostAndPort, | ||
| StorageContainerDatanodeProtocolClientSideTranslatorPB endPoint, | ||
| ConfigurationSource conf, String threadNamePrefix) { | ||
| this.endPoint = endPoint; | ||
| this.missedCount = new AtomicLong(0); | ||
| this.hostAndPort = hostAndPort; | ||
| lock = new ReentrantLock(); | ||
| this.conf = conf; | ||
| executorService = Executors.newSingleThreadExecutor( | ||
| new ThreadFactoryBuilder() | ||
| .setNameFormat(threadNamePrefix + "EndpointStateMachineTaskThread-" + hostAndPort + "-%d ") | ||
| .build()); | ||
| } | ||
|
|
||
|
|
@@ -180,7 +179,7 @@ public long getMissedCount() { | |
|
|
||
| @Override | ||
| public String getAddressString() { | ||
| return getAddress().getHostAndPortString(); | ||
|
Contributor
There was a problem hiding this comment.
— Claude Code (AI-assisted review) |
||
| } | ||
|
|
||
| public void zeroMissedCount() { | ||
|
|
@@ -192,8 +191,8 @@ public void zeroMissedCount() { | |
| * | ||
| * @return - EndPoint. | ||
| */ | ||
| public HostAndPort getAddress() { | ||
| return hostAndPort; | ||
| } | ||
|
|
||
| /** | ||
|
|
@@ -213,7 +212,7 @@ public InetSocketAddress getAddress() { | |
| */ | ||
| @Override | ||
| public String toString() { | ||
| return hostAndPort.toString(); | ||
| } | ||
|
|
||
| /** | ||
|
|
@@ -236,14 +235,8 @@ public void logIfNeeded(Exception ex) { | |
| long missedDurationSeconds = TimeUnit.MILLISECONDS.toSeconds( | ||
| this.getMissedCount() * getScmHeartbeatInterval(this.conf) | ||
| ); | ||
| LOG.warn("Unable to communicate to {} server at {} past {} seconds.", | ||
| serverName, hostAndPort, missedDurationSeconds, ex); | ||
| } | ||
|
|
||
| if (LOG.isTraceEnabled()) { | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These
HostAndPortvariables inSCMNodeInfoare nevernull. Let's addObjects.requireNonNullin the constructor instead.