HDDS-14687. Add test that OM can finalize from a snapshot#10832
Merged
errose28 merged 3 commits intoJul 23, 2026
Conversation
errose28
added
the
zdu
errose28
changed the title
Contributor
Author
|
The original implementation was flaky because it used the default 15 minute client timeout. If the client connected to the inactive OM first, it would retry for 15 minutes instead of failing over to the leader. This probably needs to be fixed in the client in a separate change. The second issue was that the test needs to wait for the snapshot install flow to fully complete before shutting down, not just for the snapshot to show up on the follower. Otherwise the OM providing the snapshot gets shut down and the OM installing it blocks its shutdown until it can complete the snapshot install. |
errose28
marked this pull request as ready for review
July 22, 2026 00:09
dombizita
reviewed
Jul 22, 2026
Contributor
Author
|
Thanks for the review, all comments are addressed in the latest commit. |
errose28
added a commit
to errose28/ozone
that referenced
this pull request
Jul 23, 2026
…ation * HDDS-14496-zdu: (57 commits) HDDS-14687. Add test that OM can finalize from a snapshot (apache#10832) HDDS-14580. Remove OM Prepare for Upgrade Code for ZDU (apache#9723) HDDS-15848. Add new upgrade action annotations for component versions (apache#10744) HDDS-15876. Remove ozone-csi (apache#10780) HDDS-14825. Add Grafana Dashboard and Metrics for ZDU (apache#10602) HDDS-15508. Add 2.2.0 to compatibility/upgrade test (apache#10782) HDDS-15867. [JDK25] Bump byte-buddy to 1.18.11 (apache#10776) HDDS-15809. Validate x-amz-copy-source-range on UploadPartCopy (apache#10711). HDDS-15678. OFS isDirectory/isFile should not trigger pipeline refresh or return block locations (apache#10741) HDDS-15171. Add available space check on follower during bootstrap. (apache#10185) HDDS-14043. Fix ls -e UnsupportedOperationException on ofs/o3fs (apache#10209) HDDS-15709. Replace random name suffix with uniqueObjectName (apache#10773) HDDS-15849. Force channel shutdown in XceiverClientGrpc.close (apache#10747) HDDS-15765. Fail fast when --node-id is omitted for OM compact/defrag on an HA cluster (apache#10699) HDDS-14989. Delay follower SCM DN server start until Ratis log catch-up. (apache#10617). HDDS-15456. Add SCM DB lookup and identify orphan(wrt SCM) and deleted-but-present containers (apache#10547) HDDS-15812. Rename test utils for naming convention (apache#10766) HDDS-15600. Fix ListObjects response for encoding-type and empty delimiter (apache#10586). HDDS-15656. Fix non-atomic data size accumulation in ContainerBalancer move callback (apache#10708) HDDS-15667. `containerbalancer status`: show stop reason and iteration details after stop (apache#10681) ... Conflicts: hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/TestOMUpgradeFinalization.java hadoop-ozone/interface-client/src/main/proto/OmClientProtocol.proto
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Prior to HDDS-14580, TestOMUpgradeFinalization used prepare for upgrade to clear OM logs and check that a follower could finalize from a snapshot. HDDS-14580 removed prepare for upgrade and that test as well. This PR restores testing for OM snapshot finalization based on reference implementations in
TestSCMHAFinalization#testSnasphotFinalizationandTestOMRatisSnapshots.What is the link to the Apache JIRA
HDDS-14687
How was this patch tested?
New test should pass.