Repository navigation
HDDS-17312. gRPC client read and EC write timeouts are truncated to whole seconds - #11694
Merged
Merged
Conversation
…hole seconds Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
jojochuang
approved these changes
Oct 23, 2026
jojochuang
left a comment
jojochuang
left a comment
Contributor
There was a problem hiding this comment.
It's a minor issue but looks good to me.
jojochuang
marked this pull request as ready for review
October 23, 2026 06:44
Contributor
Author
|
Thanks @jojochuang for the review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generated-by: Claude Code (Opus 5.5)
What changes were proposed in this pull request?
XceiverClientGrpcreadsozone.client.read.timeout, andECXceiverClientGrpcreadsozone.client.ec.grpc.write.timeout, in seconds and applies the result as the gRPC deadline in seconds. A sub-second value such as500msbecomes 0, so every request to the datanode fails immediately withDEADLINE_EXCEEDED, and1500msbecomes 1s. The short-circuit client and server already readozone.client.read.timeoutin milliseconds.This change keeps the timeout in milliseconds and uses it as the deadline in milliseconds. A value without unit still means seconds for these two keys, so existing configurations keep their meaning.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-17312
How was this patch tested?
Added
TestXceiverClientGrpcChannel#timeoutIsInMillisfor both clients with500ms,1500ms,30sand a value without unit (45). It fails without the fix. Existinghdds-clientunit tests pass.🤖 Generated with Claude Code