Repository navigation
fix: bound index I/O and validate release artifacts - #123
Conversation
|
Benchmark run · success · attempt 1 Vector index benchmark🟢 No alerts (5/5 indexes)
🟡 QPS ↓ >10% or Recall ↓ >1pp · 🔴 QPS ↓ >20% or Recall ↓ >3pp. Advisory only; QPS is measured after warmup. Absolute metrics & environmentMedians, base → PR. QPS is timed after warmup; P95 uses the first warm sweep.
Base |
leaves12138
left a comment
There was a problem hiding this comment.
Reviewed oversized IVF-RQ list streaming and block alignment, retained delta-ID window accounting, metadata allocation validation and failed-load cleanup, JNI chunked output and Java exception preservation, and the shared release-version/wheel validation gates. No blocking issues found in this head.
Local validation in an isolated source tree:
cargo test --locked --workspace --no-fail-fast: 737 passed, 2 ignored.- Release-tool Python unit tests: 26 passed.
- JDK 8 Java API execution and the native output/panic-boundary regression completed successfully, including a run with
-Xcheck:jni. - Built a Linux x86-64 wheel, verified its legal/native contents, and passed the new isolated-install smoke test covering native loading, training, writing, reading, and searching.
cargo fmt --all -- --checkand workspace/all-target Clippy with-D warningspassed.
All 10 current GitHub check runs are successful. The local wheel was a Linux platform wheel, not a repaired manylinux artifact; I did not execute the macOS/Windows release workflows or publish artifacts locally.
(cherry picked from commit c2758d9)
Large IVF-RQ partitions could bypass the 64 MiB batch limit, malformed headers could drive large allocations, and JNI output was limited by a single Java byte array. Release jobs also lacked a shared source-version check and runtime validation of their final wheels.
Changes
Validation
cargo test --workspace --no-fail-fast: 737 passed, 2 existing ignored.python3 -m unittest discover -s tools/tests -p 'test_*.py' -q: 26 passed, including final/RC tags, mismatches, and non-tag inputs.cargo clippy --all-targets --workspace -- -D warnings, formatting, license-header, and binary legal-inventory checks passed.-Xcheck:jni, buffer reuse, byte order, and original exception identity.Linux x86-64/aarch64 and Windows final-wheel runtime validation is configured as a required step in the release workflows; it still needs the corresponding CI runners.